[asterisk-bugs] [Asterisk 0014331]: [patch] reg->username is parsed for each registration refresh rather than once on sip reload

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14331 
====================================================================== 
Reported By:                Nick_Lewis
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   14331
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.1-beta4 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-26 06:19 CST
Last Modified:              2009-07-16 11:18 CDT
====================================================================== 
Summary:                    [patch] reg->username is parsed for each
registration refresh rather than once on sip reload
Description: 
The registration string can contain an expanded user portion of the form
user at domain (and possibly user at domain:domainport). This expanded user
portion is currently stored in reg->username and parsed each time there is
a registration refresh. It would be better if the configuration was parsed
only once and the sip_registry structure contained the atomic fields
separately through the addition of, for example, reg->regdomain and
reg->regdomainport elements
====================================================================== 

---------------------------------------------------------------------- 
 (0107850) dvossel (administrator) - 2009-07-16 11:18
 https://issues.asterisk.org/view.php?id=14331#c107850 
---------------------------------------------------------------------- 
The head is what we call trunk. (svn checkout
http://svn.digium.com/svn/asterisk/trunk).  I've looked over the patch and
it looks pretty good!  A few things have changed in transmit_register()
involving string creation.  If you are willing to make the changes and
bring it up to date for merging, I'll take a look at it again and see if we
can't get it committed!  I'm fairly active on the tracker, so if you update
the patch I should be able to review it quickly.  I won't let it sit around
like it did last time.

Since this is tweak and not a bug fix/feature, if you don't have any plans
to do additional work to the patch let me know so we can close the issue.
Thanks for the contribution. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-16 11:18 dvossel        Note Added: 0107850                          
======================================================================