[asterisk-bugs] [Asterisk 0014239]: [patch] 491-request pending is sent out of dialog

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14239 
====================================================================== 
Reported By:                klaus3000
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14239
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.4.22 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-14 07:33 CST
Last Modified:              2009-07-13 11:40 CDT
====================================================================== 
Summary:                    [patch] 491-request pending is sent out of dialog
Description: 
Hi!

Asterisk does not handle the following scenario correctly:

--INVITE-->
<-407------
[ACK is lost]

--INVITE w/credentials-->
<-----------491----------

The 491 is wrong as the 491 is only allowed for in-dialog requests. As the
first INVITE is not accepted there is no dialog set up. Thus, Asterisk may
retransmit the 407 to trigger retransmission of the ACK, but this must be
independet from the second INVITE which should be accepted instead of
rejecting with 491 - even if the ACK was not received.

I checked lates SVN commits in chan_sip and itlooks like the problem is
still there.

This issue is maybe related to https://issues.asterisk.org/view.php?id=13849
(although in https://issues.asterisk.org/view.php?id=13849 the second
INVITE is in-dialog).
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013849 problem handling race condition - reINV...
====================================================================== 

---------------------------------------------------------------------- 
 (0107687) klaus3000 (reporter) - 2009-07-13 11:40
 https://issues.asterisk.org/view.php?id=14239#c107687 
---------------------------------------------------------------------- 
I've tested the patch and it works: I tested:
- dropped ACK 
- delayed ACK (2 seconds too late)

I did not made extensive tests, but the "491 request pending" problem in
the described scenario is solved now.

I also re-tested the scenario in https://issues.asterisk.org/view.php?id=13849
(reINVITE overtakes ACK) and it
still behaves correct. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-13 11:40 klaus3000      Note Added: 0107687                          
======================================================================