[asterisk-bugs] [Asterisk 0014769]: [patch] Improvements/fixes for app_fax

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14769 
====================================================================== 
Reported By:                andrew
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14769
Category:                   Applications/app_fax
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 184382 
Request Review:              
====================================================================== 
Date Submitted:             2009-03-26 15:14 CDT
Last Modified:              2009-07-10 13:20 CDT
====================================================================== 
Summary:                    [patch] Improvements/fixes for app_fax
Description: 

I was working on a backport of app_fax to asterisk 1.4 branch.

It works great now, but the original code was causing errors to be logged
(a new issue as of 1.4.24, see bug id
https://issues.asterisk.org/view.php?id=14723). As I looked into the code
more I found what I think a problems/bugs. Here is a patch (for 1.6 trunk)
for my "improvements/fixes".

I'm using SPANDSP 0.0.6pre7 and testing with SIP using an external PSTN
gateway (AS5300). I can send a fax from the system to the same system
(using the PSTN), so it seems happy. I also tested with a normal fax
machine. RX works way better than TX for me.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014812 ast_read() used with incorrect ast_wait...
====================================================================== 

---------------------------------------------------------------------- 
 (0107588) andrew (reporter) - 2009-07-10 13:20
 https://issues.asterisk.org/view.php?id=14769#c107588 
---------------------------------------------------------------------- 
I see the changes in trunk from https://issues.asterisk.org/view.php?id=14849
and https://issues.asterisk.org/view.php?id=15480

The loop changes were mostly for the waitfor bugs, plus it is a better
design. The current trunk still generates some RTP Read errors with T38
(for sending), but trunk works for me with both audio and T38 (on cisco
AS5300).

There are still other improvements in this patch that I think are worth
adding to trunk. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-10 13:20 andrew         Note Added: 0107588                          
======================================================================