[asterisk-bugs] [Asterisk 0014239]: 491-request pending is sent out of dialog

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14239 
====================================================================== 
Reported By:                klaus3000
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14239
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.22 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-14 07:33 CST
Last Modified:              2009-07-09 11:08 CDT
====================================================================== 
Summary:                    491-request pending is sent out of dialog
Description: 
Hi!

Asterisk does not handle the following scenario correctly:

--INVITE-->
<-407------
[ACK is lost]

--INVITE w/credentials-->
<-----------491----------

The 491 is wrong as the 491 is only allowed for in-dialog requests. As the
first INVITE is not accepted there is no dialog set up. Thus, Asterisk may
retransmit the 407 to trigger retransmission of the ACK, but this must be
independet from the second INVITE which should be accepted instead of
rejecting with 491 - even if the ACK was not received.

I checked lates SVN commits in chan_sip and itlooks like the problem is
still there.

This issue is maybe related to https://issues.asterisk.org/view.php?id=13849
(although in https://issues.asterisk.org/view.php?id=13849 the second
INVITE is in-dialog).
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013849 problem handling race condition - reINV...
====================================================================== 

---------------------------------------------------------------------- 
 (0107513) mmichelson (administrator) - 2009-07-09 11:08
 https://issues.asterisk.org/view.php?id=14239#c107513 
---------------------------------------------------------------------- 
klaus3000: It appears that this bug may be easy to fix, simply by modifying
what was done for https://issues.asterisk.org/view.php?id=13849 to behave the
same way for this scenario as well.

I just need to verify that this is correct. Is it acceptable to just
accept the INVITE with credentials as though it is serving as both the ACK
for the previous INVITE transaction and as the start of a new INVITE
transaction? If so, then this can probably be done with a one-line change. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-09 11:08 mmichelson     Note Added: 0107513                          
======================================================================