[asterisk-bugs] [Asterisk 0015374]: [patch] VMWI not sent after every OnHook, only when messages changes from None to Some, or Some to None

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15374 
====================================================================== 
Reported By:                alecdavis
Assigned To:                dbailey
====================================================================== 
Project:                    Asterisk
Issue ID:                   15374
Category:                   Channels/chan_dahdi
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 201829 
Request Review:              
====================================================================== 
Date Submitted:             2009-06-22 05:06 CDT
Last Modified:              2009-07-07 20:44 CDT
====================================================================== 
Summary:                    [patch] VMWI not sent after every OnHook, only when
messages changes from None to Some, or Some to None
Description: 
In sig_analog.c
Function: analog_handle_event
 EVENT_ONHOOK doesn't force VMWI updates any more.

case ANALOG_EVENT_ONHOOK
      switch (p->sig) {
                case ANALOG_SIG_FXOLS:
                case ANALOG_SIG_FXOGS:
                case ANALOG_SIG_FXOKS:
needs                 p->msgstate = -1;  /* force VMWI update */   

As yet 'msgstate' hasn't been handled in the conversion to sig_analog
====================================================================== 

---------------------------------------------------------------------- 
 (0107466) alecdavis (reporter) - 2009-07-07 20:44
 https://issues.asterisk.org/view.php?id=15374#c107466 
---------------------------------------------------------------------- 
Referring to ETSI EN 300 659-3 V1.3.1 (2001-01)

5.4.14 Number of Messages parameter

Octet   Binary          Hexadecimal     Contents
number  coding          coding
1       0001 0011       13              Number of Messages
2       0000 0001       01              Parameter length (1)
3       0000 0000       00              No messages
        0000 0001       01              1 message or unspecified number of
messages waiting
        0000 0010       02
        to                              Number of messages waiting in the
message system
        1111 1111       FF

The concept of, No messages or some is OK, but shouldn't it support up to
255 messages.

Sorry if formatting doesn't stay in tact. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-07 20:44 alecdavis      Note Added: 0107466                          
======================================================================