[asterisk-bugs] [Asterisk 0015413]: [patch] Mapping of extension state to device state is incorrect

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15413 
====================================================================== 
Reported By:                legart
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   15413
Category:                   Functions/func_devstate
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     closed
Target Version:             1.4.26
Asterisk Version:           1.4.26-rc4 
Regression:                 Yes 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-06-29 03:56 CDT
Last Modified:              2009-07-02 11:03 CDT
====================================================================== 
Summary:                    [patch] Mapping of extension state to device state
is incorrect
Description: 
It seems that the fix for bug 15057 has introduced a different bug. A
users state can never be RINGING.

> > set global DEVSTATE(Custom:XXXX) RINGING
c3pbx*CLI>
    -- Global variable DEVSTATE(Custom:XXXX) set to RINGING
[Jun 26 15:34:54]  Extension Changed XXXX[default] new state Busy for
Notify User XXXX

Setting e.g. RINGINGINUSE works, but RINGING always gets
Busy as device state result.

The hint for a SIP peer is also Busy while the device is ringing.

This makes it impossible to pickup ringning channels from e.g. a
SNOM phone.

Tested with 1.4.26rc3 and rc4. Looks like it was introduced with
1.4.26rc2.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015057 [patch] hints with 2+ devices that incl...
====================================================================== 

---------------------------------------------------------------------- 
 (0107346) svnbot (reporter) - 2009-07-02 11:03
 https://issues.asterisk.org/view.php?id=15413#c107346 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 204710

_U  trunk/
U   trunk/include/asterisk/devicestate.h
U   trunk/main/devicestate.c
U   trunk/main/pbx.c

------------------------------------------------------------------------
r204710 | dvossel | 2009-07-02 11:03:44 -0500 (Thu, 02 Jul 2009) | 21
lines

Merged revisions 204681 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r204681 | dvossel | 2009-07-02 10:05:57 -0500 (Thu, 02 Jul 2009) | 14
lines
  
  Improved mapping of extension states from combined device states.
  
  This fixes a few issues with incorrect extension states and adds
  a cli command, core show device2extenstate, to display all possible
  state mappings.
  
  (closes issue https://issues.asterisk.org/view.php?id=15413)
  Reported by: legart
  Patches:
        exten_helper.diff uploaded by dvossel (license 671)
  Tested by: dvossel, legart, amilcar
  
  Review: https://reviewboard.asterisk.org/r/301/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=204710 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-02 11:03 svnbot         Checkin                                      
2009-07-02 11:03 svnbot         Note Added: 0107346                          
======================================================================