[asterisk-bugs] [Asterisk 0014674]: [patch] Dial application with the 'n' option not removing introductions

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14674 
====================================================================== 
Reported By:                ulogic
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14674
Category:                   Applications/app_dial
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Asterisk Version:           1.6.0.7-rc1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-03-16 10:35 CDT
Last Modified:              2009-07-01 16:13 CDT
====================================================================== 
Summary:                    [patch] Dial application with the 'n' option not
removing introductions
Description: 
When using the 'p' screening option with the 'n' non-persistent option, the
introductions are not supposed to be saved in the priv-callerintros
directory.  However, the only time they are deleted in the current code is
when the called party accepts the call by pressing the 1 key.

Caller A makes a call and dials the extension for called party P.  The
call screening asks A to say the name to present to P.  P does not answer
the call because P is on the phone, away from the desk, or sent the call to
voice mail.  Later caller B make a call from the phone number.  Because
announcement file still exists for that phone number, no prompt for the
name is given, and the announcement given to P is the response from A.  P
picks up the phone thinking that A has called and is surprised to find B on
the line.

This behavior goes back to Asterisk version 1.2.

Also the help messages for the p and P options are not real clear.


====================================================================== 

---------------------------------------------------------------------- 
 (0107318) ulogic (reporter) - 2009-07-01 16:13
 https://issues.asterisk.org/view.php?id=14674#c107318 
---------------------------------------------------------------------- 
The patch I submitted is compartmentalized within the privacy handling
section of app_dial.c and I was comfortable making that change.  It did
take care of the primary symptom without breaking anything else.

I do agree that it would be better to delete the file at the end of the
call.  One difficulty that I see is that the call could be transferred to
another extension, either though a features.conf action or directly from
the peer's phone.  In the latter case, the dialplan probably won't use the
'n' option for the Dial() application when placing an intra-extension call.
 That means we have to save the OPT_SCREEN_NOINTRO flag somewhere in the
channel object, and copy it to the new channel from the channel that is on
hold when the transfer occurs.  We want to set the flag if the option is
present, but only clear it if there was no previous peer.  This way we
could actually play the intro to the target extension when the transfer is
made.  The file would not be deleted until the initial caller disconnects. 
I realize that the CDR time will get reset on the transferred call so the
fstat test will cause the announcement file to be deleted in the current
implementation.

I must admit that I am not familiar enough with the (sparsely commented)
code and the flow of the call processing to attempt that change without
further study and time commitment.

I have tested the direct phone transfer option with a Linksys SPA241, an
AAstra 9112 and 480i CT, and a Snom 320 and 360.  The Snom phones pass the
original caller ID on the transfer, but the other phones do not.  This is
not really relevant but just an interesting note. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-01 16:13 ulogic         Note Added: 0107318                          
======================================================================