[asterisk-bugs] [Asterisk 0014274]: Revision 169154 One Touch Park cannot be more than once per call

Fri Jan 30 11:46:52 CST 2009

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14274 
====================================================================== 
Reported By:                aragon
Assigned To:                otherwiseguy
====================================================================== 
Project:                    Asterisk
Issue ID:                   14274
Category:                   Applications/app_parkandannounce
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           1.4.23-rc3 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 169154 
Request Review:              
====================================================================== 
Date Submitted:             2009-01-19 08:41 CST
Last Modified:              2009-01-30 11:46 CST
====================================================================== 
Summary:                    Revision 169154 One Touch Park cannot be more than
once per call
Description: 
A calls B
B parks A with one touch park feature
Caller A is parked
B retrieves parked call and tries park again with one touch park feature
B cannot park this caller again

I recommend that otherwiseguy be assigned to this ticket since it was his
revisions which fixed most parking issues in Asterisk 1.4 SVN.

Revision 168981 - Directory Listing
Modified Fri Jan 16 22:59:41 2009 UTC (19 hours, 25 minutes ago) by
twilson

Merged revisions 168941 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r168941 | twilson | 2009-01-16 16:16:23 -0600 (Fri, 16 Jan 2009) | 19
lines

 Merged revisions 168716 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4

 ........
  r168716 | twilson | 2009-01-15 12:22:49 -0600 (Thu, 15 Jan 2009) | 12
lines

  Convert call to park_call_full to masq_park_call_announce

  Since we removed the AST_PBX_KEEPALIVE return value, we need to use
masqueraded
  parking, otherwise we will try to call ast_hangup() in __pbx_run() and
in
  do_parking_thread() and then promptly crash.
  (closes issue http://bugs.digium.com/view.php?id=14215)
     Reported by: waverly360   
     Tested by: otherwiseguy
  (closes issue http://bugs.digium.com/view.php?id=14228)
     Reported by: kobaz
     Tested by: otherwiseguy
====================================================================== 

---------------------------------------------------------------------- 
 (0099138) svnbot (reporter) - 2009-01-30 11:46
 http://bugs.digium.com/view.php?id=14274#c99138 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 172517

U   branches/1.4/CHANGES
U   branches/1.4/apps/app_dial.c
U   branches/1.4/configs/features.conf.sample
U   branches/1.4/doc/channelvariables.txt
U   branches/1.4/include/asterisk/global_datastores.h
U   branches/1.4/main/global_datastores.c
U   branches/1.4/res/res_features.c

------------------------------------------------------------------------
r172517 | twilson | 2009-01-30 11:46:50 -0600 (Fri, 30 Jan 2009) | 37
lines

Fix feature inheritance with builtin features

When using builtin features like parking and transfers, the AST_FEATURE_*
flags
would not be set correctly for all instances when either performing a
builtin
attended transfer, or parking a call and getting the timeout callback. 
Also,
there was no way on a per-call basis to specify what features someone
should
have on picking up a parked call (since that doesn't involve the Dial()
command).
There was a global option for setting whether or not all users who pickup
a
parked call should have AST_FEATURE_REDIRECT set, but nothing for
DISCONNECT,
AUTOMON, or PARKCALL.

This patch:
1) adds the BRIDGE_FEATURES dialplan variable which can be set either in
the
dialplan or with setvar in channels that support it.  This variable can be
set
to any combination of 't', 'k', 'w', and 'h' (case insensitive matching of
the
equivalent dial options), to set what features should be activated on this
channel.  The patch moves the setting of the features datastores into the
bridging code instead of app_dial to help facilitate this.

2) adds global options parkedcallparking, parkedcallhangup, and
parkedcallrecording to be similar to the parkedcalltransfers option for
globally setting features.

3) has builtin_atxfer call builtin_parkcall if being transfered to the
parking
extension since tracking everything through multiple masquerades, etc. is
difficult and error-prone

4) attempts to fix all cases of return calls from parking and completed
builtin
transfers not having the correct permissions
(closes issue http://bugs.digium.com/view.php?id=14274)
Reported by: aragon
Patches: 
      fix_feature_inheritence.diff.txt uploaded by otherwiseguy (license
396)
Tested by: aragon, otherwiseguy

Review http://reviewboard.digium.com/r/138/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=172517 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-30 11:46 svnbot         Note Added: 0099138                          
======================================================================