[asterisk-bugs] [Asterisk 0014353]: [patch] RemoveQueueMember could remove realtime members too

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14353 
====================================================================== 
Reported By:                fiddur
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   14353
Category:                   Applications/app_queue
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 171829 
Request Review:              
====================================================================== 
Date Submitted:             2009-01-28 06:46 CST
Last Modified:              2009-01-30 00:42 CST
====================================================================== 
Summary:                    [patch] RemoveQueueMember could remove realtime
members too
Description: 
If RemoveQueueMember is called for a realtime member, it only returned
"Member not dynamic".

I added the code to remove realtime members too.  Patch follows.
====================================================================== 

---------------------------------------------------------------------- 
 (0099114) fiddur (reporter) - 2009-01-30 00:42
 http://bugs.digium.com/view.php?id=14353#c99114 
---------------------------------------------------------------------- 
Thank you for pointing out the memory leak.  I see there are more places in
app_queue.c that leaks then; I mostly copied update_realtime_member_field
and modified - I'm adding ast_variables_destroy to both.

Having the standard manager and dialplan applications also affect realtime
databases helps to integrate separate applications.  It would extend to
more connections between dynamic and realtime, e.g. maybe making dynamic
adding of queue-members add to realtime if the queue is specified in
realtime and there is a realtime queue member-table.  Then, an application
that is only aware of the realtime db can make it's changes there, while
you can still use AMI applications (like asternics op_panel) at the same
time.  I guess that is a design strategic decision, but I think it would be
a useful design, and the right way.
On the other hand, I can imagine that people who are used to the realtime
tables only changed by their application and not by asterisk wouldn't want
this, if they for example cache the tables or don't re-read them assuming
noone else changes them.

If you decide to go with my way of thinking, I'm prepared to do more
coding for that.

I will upload a new patch with the memory leaks fixed. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-30 00:42 fiddur         Note Added: 0099114                          
======================================================================