[asterisk-bugs] [Asterisk 0014331]: [patch] reg->username is parsed for each registration refresh rather than once on sip reload

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14331 
====================================================================== 
Reported By:                Nick_Lewis
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14331
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     confirmed
Asterisk Version:           1.6.1-beta4 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-26 06:19 CST
Last Modified:              2009-01-29 10:32 CST
====================================================================== 
Summary:                    [patch] reg->username is parsed for each
registration refresh rather than once on sip reload
Description: 
The registration string can contain an expanded user portion of the form
user at domain (and possibly user at domain:domainport). This expanded user
portion is currently stored in reg->username and parsed each time there is
a registration refresh. It would be better if the configuration was parsed
only once and the sip_registry structure contained the atomic fields
separately through the addition of, for example, reg->regdomain and
reg->regdomainport elements
====================================================================== 

---------------------------------------------------------------------- 
 (0099066) Nick_Lewis (reporter) - 2009-01-29 10:32
 http://bugs.digium.com/view.php?id=14331#c99066 
---------------------------------------------------------------------- 
Is this patch ok as is? 

Once this is applied it will be easier to get the cli to work with AORs
(see issue 14248) because the AORs will always be ("%s@%s", reg->username,
reg->regdomain) irrespective of the registrar host 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-29 10:32 Nick_Lewis     Note Added: 0099066                          
======================================================================