[asterisk-bugs] [Asterisk 0014274]: Revision 169154 One Touch Park cannot be more than once per call

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14274 
====================================================================== 
Reported By:                aragon
Assigned To:                otherwiseguy
====================================================================== 
Project:                    Asterisk
Issue ID:                   14274
Category:                   Applications/app_parkandannounce
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.23-rc3 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 169154 
Request Review:              
====================================================================== 
Date Submitted:             2009-01-19 08:41 CST
Last Modified:              2009-01-28 17:06 CST
====================================================================== 
Summary:                    Revision 169154 One Touch Park cannot be more than
once per call
Description: 
A calls B
B parks A with one touch park feature
Caller A is parked
B retrieves parked call and tries park again with one touch park feature
B cannot park this caller again

I recommend that otherwiseguy be assigned to this ticket since it was his
revisions which fixed most parking issues in Asterisk 1.4 SVN.

Revision 168981 - Directory Listing
Modified Fri Jan 16 22:59:41 2009 UTC (19 hours, 25 minutes ago) by
twilson

Merged revisions 168941 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r168941 | twilson | 2009-01-16 16:16:23 -0600 (Fri, 16 Jan 2009) | 19
lines
 
 Merged revisions 168716 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
  r168716 | twilson | 2009-01-15 12:22:49 -0600 (Thu, 15 Jan 2009) | 12
lines
  
  Convert call to park_call_full to masq_park_call_announce
  
  Since we removed the AST_PBX_KEEPALIVE return value, we need to use
masqueraded
  parking, otherwise we will try to call ast_hangup() in __pbx_run() and
in
  do_parking_thread() and then promptly crash.
  (closes issue http://bugs.digium.com/view.php?id=14215)
     Reported by: waverly360   
     Tested by: otherwiseguy
  (closes issue http://bugs.digium.com/view.php?id=14228)
     Reported by: kobaz
     Tested by: otherwiseguy
====================================================================== 

---------------------------------------------------------------------- 
 (0099001) otherwiseguy (administrator) - 2009-01-28 17:06
 http://bugs.digium.com/view.php?id=14274#c99001 
---------------------------------------------------------------------- 
aragon: Ok, I have attached fix_feature_inheritence.diff.txt which should
fix this and a host of other problems I came across with feature
inheritance in both parking and builtin attended transfers.  To solve the
specific problem that you are experiencing there are now two ways to solve
this.

First, there is now a global option in features.conf similar to the
parkedcalltransfers option for transfers for all builtin features
(parkedcallparking, parkedcallhangup, and parkedcallrecording) that will
give permissions to the Pickup() caller for that particular feature.  You
can see the options for them in the features.conf.sample after applying the
patch.  2) You can also now set the BRIDGE_FEATURES dialplan variable (most
likely via the setvar option in sip.conf, etc.) with any combination of
'T', 'K', 'W', and 'H' (which match the dial options--for transfer, park,
monitor, and hangup) which will give those features to the channel the
variable is set on.  For example in sip.conf:
[phone]
type=friend
host=dyanmic
secret=1234
context=default
setvar=BRIDGE_FEATURES=tk

would give SIP/phone the ability to transfer or one-touch park (if those
features are defined in features.conf) for the life of that channel,
regardless of whether or not Dial() is used; if Pickup() is called via a
parked call, for example.

There are quite a few code changes as far as feature inheritance is
concerned, so if you could thoroughly test things, I'd appreciate it! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-28 17:06 otherwiseguy   Note Added: 0099001                          
======================================================================