[asterisk-bugs] [Asterisk 0014241]: [patch] h exten getting run at the wrong time

Wed Jan 28 14:41:01 CST 2009

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14241 
====================================================================== 
Reported By:                jmls
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   14241
Category:                   Resources/res_features
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     closed
Target Version:             1.4.24
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 168602 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-01-14 12:34 CST
Last Modified:              2009-01-28 14:41 CST
====================================================================== 
Summary:                    [patch] h exten getting run at the wrong time
Description: 
in 1.4 svn, If A calls B, and A is redirected via AMI to another extension
(meetme room for example), the h extension is being run on A before it is
redirected.

The h extension should be run on A when A hangs up.
====================================================================== 

---------------------------------------------------------------------- 
 (0098978) svnbot (reporter) - 2009-01-28 14:41
 http://bugs.digium.com/view.php?id=14241#c98978 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 172065

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_channelredirect.c
U   branches/1.6.0/include/asterisk/channel.h
U   branches/1.6.0/main/features.c
U   branches/1.6.0/main/manager.c
U   branches/1.6.0/main/pbx.c

------------------------------------------------------------------------
r172065 | murf | 2009-01-28 14:41:00 -0600 (Wed, 28 Jan 2009) | 59 lines

Merged revisions 172063 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r172063 | murf | 2009-01-28 13:31:06 -0700 (Wed, 28 Jan 2009) | 52 lines

  Merged revisions 172030 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4

  ........
    r172030 | murf | 2009-01-28 11:51:16 -0700 (Wed, 28 Jan 2009) | 46
lines

    This patch fixes h-exten running misbehavior in manager-redirected 
    situations.

    What it does:
    1. A new Flag value is defined in include/asterisk/channel.h,
     AST_FLAG_BRIDGE_HANGUP_DONT, which used as a messenge to the
     bridge hangup exten code not to run the h-exten there (nor
     publish the bridge cdr there). It will done at the pbx-loop
     level instead.
    2. In the manager Redirect code, I set this flag on the channel
     if the channel has a non-null pbx pointer. I did the same for the
     second (chan2) channel, which gets run if name2 is set...
     and the first succeeds.
    3. I restored the ending of the cdr for the pbx loop h-exten
     running code. Don't know why it was removed in the first place.
    4. The first attempt at the fix for this bug was to place code
       directly in the async_goto routine, which was called from a
       large number of places, and could affect a large number of
       cases, so I tested that fix against a fair number of transfer
       scenarios, both with and without the patch. In the process,
       I saw that putting the fix in async_goto seemed not to affect
       any of the blind or attended scenarios, but still, I was
       was highly concerned that some other scenarios I had not tested
       might be negatively impacted, so I refined the patch to 
       its current scope, and jmls tested both. In the process, tho,
       I saw that blind xfers in one situation, when the one-touch
       blind-xfer feature is used by the peer, we got strange 
       h-exten behavior.  So, I  inserted code to swap CDRs and
       to set the HANGUP_DONT field, to get uniform behavior.
    5. I added code to the bridge to obey the HANGUP_DONT flag,
       skipping both publishing the bridge CDR, and running
       the h-exten; they will be done at the pbx-loop (higher)
       level instead.
    6. I removed all the debug logs from the patch before committing.
    7. I moved the AUTOLOOP set/reset in the h-exten code in res_features
       so it's only done if the h-exten is going to be run. A very
       minor performance improvement, but technically correct.

    (closes issue http://bugs.digium.com/view.php?id=14241)
    Reported by: jmls
    Patches:
          14241_redirect_no_bridgeCDR_or_h_exten_via_transfer uploaded by
murf (license 17)
    Tested by: murf, jmls
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=172065 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-28 14:41 svnbot         Note Added: 0098978                          
======================================================================