[asterisk-bugs] [Asterisk 0014206]: Can't pickup using *8 after updating asterisk to 1.4.23-rc3

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14206 
====================================================================== 
Reported By:                francesco_r
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   14206
Category:                   Core/PBX
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Target Version:             1.4.24
Asterisk Version:           1.4.23-rc3 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-01-10 08:53 CST
Last Modified:              2009-01-23 09:49 CST
====================================================================== 
Summary:                    Can't pickup using *8 after updating asterisk to
1.4.23-rc3
Description: 
I have updated a 1.4.22 installation to 1.4.23-rc3 and now i can't pickup
using the default value *8.
If 553 call SIP/552 and SIP/551 pickup with *8, 551 hear 553 but 552 keep
ringing and 553 continue to listen the ringing.

In my case 553 is an ISDN phone but is the same with pure SIP environment.
And in the setup there is no NAT or external router. All is in the same
lan.
I have attached a full debug with sip debug and history enabled.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
duplicate of        0014240 Broken mISDN pickup started after revis...
====================================================================== 

---------------------------------------------------------------------- 
 (0098565) svnbot (reporter) - 2009-01-23 09:49
 http://bugs.digium.com/view.php?id=14206#c98565 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 170394

_U  branches/1.6.0/
U   branches/1.6.0/main/channel.c

------------------------------------------------------------------------
r170394 | mmichelson | 2009-01-23 09:49:24 -0600 (Fri, 23 Jan 2009) | 44
lines

Merged revisions 170393 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
r170393 | mmichelson | 2009-01-23 09:44:27 -0600 (Fri, 23 Jan 2009) | 36
lines

Merged revisions 170392 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r170392 | mmichelson | 2009-01-23 09:40:39 -0600 (Fri, 23 Jan 2009) | 28
lines

Fix broken call pickup

There was a subtle change in ast_do_masquerade which
resulted in failed attempts to pickup calls. The problem
was that the value of the AST_FLAG_OUTGOING flag was
copied from the clone to the original channel. In the case
of call pickup, this meant that the AST_FLAG_OUTGOING flag
ended up being cleared on the channel that was attempting
to execute the pickup.

Because this flag was not set, when ast_read came across
an answer frame, it ignored it. The result of this was that
the calling channel was never properly answered.

This fix changes the behavior in ast_do_masquerade to set
the flags on the original channel to the union of the flags
on the clone channel. This way, if the AST_FLAG_OUTGOING
flag is set on either of the two channels involved in the
masquerade, the resulting channel will have the flag set
as well.

(closes issue http://bugs.digium.com/view.php?id=14206)
Reported by: francesco_r
Patches:
      14206.patch uploaded by putnopvut (license 60)
Tested by: francesco_r, aragon, putnopvut


........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=170394 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-23 09:49 svnbot         Checkin                                      
2009-01-23 09:49 svnbot         Note Added: 0098565                          
======================================================================