[asterisk-bugs] [Asterisk 0014274]: Revision 169154 One Touch Park cannot be more than once per call

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14274 
====================================================================== 
Reported By:                aragon
Assigned To:                otherwiseguy
====================================================================== 
Project:                    Asterisk
Issue ID:                   14274
Category:                   Applications/app_parkandannounce
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.23-rc3 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 169154 
Request Review:              
====================================================================== 
Date Submitted:             2009-01-19 08:41 CST
Last Modified:              2009-01-22 15:34 CST
====================================================================== 
Summary:                    Revision 169154 One Touch Park cannot be more than
once per call
Description: 
A calls B
B parks A with one touch park feature
Caller A is parked
B retrieves parked call and tries park again with one touch park feature
B cannot park this caller again

I recommend that otherwiseguy be assigned to this ticket since it was his
revisions which fixed most parking issues in Asterisk 1.4 SVN.

Revision 168981 - Directory Listing
Modified Fri Jan 16 22:59:41 2009 UTC (19 hours, 25 minutes ago) by
twilson

Merged revisions 168941 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r168941 | twilson | 2009-01-16 16:16:23 -0600 (Fri, 16 Jan 2009) | 19
lines
 
 Merged revisions 168716 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
  r168716 | twilson | 2009-01-15 12:22:49 -0600 (Thu, 15 Jan 2009) | 12
lines
  
  Convert call to park_call_full to masq_park_call_announce
  
  Since we removed the AST_PBX_KEEPALIVE return value, we need to use
masqueraded
  parking, otherwise we will try to call ast_hangup() in __pbx_run() and
in
  do_parking_thread() and then promptly crash.
  (closes issue http://bugs.digium.com/view.php?id=14215)
     Reported by: waverly360   
     Tested by: otherwiseguy
  (closes issue http://bugs.digium.com/view.php?id=14228)
     Reported by: kobaz
     Tested by: otherwiseguy
====================================================================== 

---------------------------------------------------------------------- 
 (0098500) otherwiseguy (administrator) - 2009-01-22 15:34
 http://bugs.digium.com/view.php?id=14274#c98500 
---------------------------------------------------------------------- 
I'm working on this and understand the issue, it is just going to take a
bit of time to fix correctly.  Basically, there is no way to fix it within
the current structure of doing call-based feature permissions.  When I'm
done there will probably be a global option for all bridge features like
the parkedtransfers feature in features.conf, as well as a dialplan
variable that can be added to channel config files via the setvar option
that will allow features to be controlled per-device (in addition to the
setting of features via Dial()).  The problem with call pickup is that it
doesn't involve a dial(), so no features are set and we can't just inherit
what the original parker had, because it is being picked up by a completely
different channel.

In addition to this, I've found several cases where features are being
incorrectly inherited/lost when a parking timeout occurs.  Hopefully, in
the next day or two I can get a fix for all (or at least most) of the
cases. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-22 15:34 otherwiseguy   Note Added: 0098500                          
======================================================================