[asterisk-bugs] [Asterisk 0014305]: pbx.c's show_dialplan_helper prints an "\r\n" at the end of every call

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14305 
====================================================================== 
Reported By:                martins
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14305
Category:                   Core/PBX
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 169943 
Request Review:              
====================================================================== 
Date Submitted:             2009-01-21 20:21 CST
Last Modified:              2009-01-22 11:08 CST
====================================================================== 
Summary:                    pbx.c's show_dialplan_helper prints an "\r\n" at the
end of every call
Description: 
Asterisk-Java has expected to consistently see any Manager responses of the
"response: Follows" style to contain whatever response in a single
"\r\n"-ending line somewhere in the response, which could contain multiple
"\n", but ends in "--END COMMAND--\r\n". We've had much success with this
consistent behavior. In fact, it's one of the only ways we can recognize
the data lines that come with a command (because they aren't delimited with
"\r\n", but only an "\n").

Doing an "action: Command" with "dialplan show" as the command fails this
expectation. See additional information for more.
====================================================================== 

---------------------------------------------------------------------- 
 (0098457) jamesgolovich (manager) - 2009-01-22 11:08
 http://bugs.digium.com/view.php?id=14305#c98457 
---------------------------------------------------------------------- 
I'd agree this is not consistent behavior.  A quick scan of the code shows
the only usage of "\r\n" is pretty much just in manager and http code.  in
pbx.c show_dialplan_helper and show_debug_helper cli writes use "\r\n".

Based on the comments in the code I suspect these functions were both
written/modified by the same person

Trivial patch attached 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-22 11:08 jamesgolovich  Note Added: 0098457                          
======================================================================