[asterisk-bugs] [Asterisk 0014289]: utils/refcounter segfaults due to reference of count1_obj when its NULL

[Asterisk Bug Tracker]

The following issue requires your FEEDBACK. 
====================================================================== 
http://bugs.digium.com/view.php?id=14289 
====================================================================== 
Reported By:                jamesgolovich
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   14289
Category:                   Utilities/General
Reproducibility:            sometimes
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 169487 
Request Review:              
====================================================================== 
Date Submitted:             2009-01-20 14:46 CST
Last Modified:              2009-01-21 09:11 CST
====================================================================== 
Summary:                    utils/refcounter segfaults due to reference of
count1_obj when its NULL
Description: 
I'm not sure if this happens to everyone or just something unique in my
situation.  First time I've played with refcounter.

Line 164 prints an error if count1_obj doesn't exist but then tries to
reference count1_obj->addr which is a guaranteed segfault.

Not sure what the appropriate action is here, in my copy I just removed
the reference so the error message is just printed.

-                               printf("BAD: object %x appears without
previous allocation marker!\n", count1_obj->addr);
+                               printf("BAD: object appears without
previous allocation marker!\n");

====================================================================== 

---------------------------------------------------------------------- 
 (0098314) seanbright (manager) - 2009-01-21 09:11
 http://bugs.digium.com/view.php?id=14289#c98314 
---------------------------------------------------------------------- 
What about just changing:

  count1_obj->addr

to:

  un

 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-21 09:11 seanbright     Note Added: 0098314                          
2009-01-21 09:11 seanbright     Status                   assigned => feedback
======================================================================