[asterisk-bugs] [Asterisk 0014264]: compilation warning for main/editline/history

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14264 
====================================================================== 
Reported By:                dimas
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14264
Category:                   General
Reproducibility:            have not tried
Severity:                   tweak
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 168729 
Request Review:              
====================================================================== 
Date Submitted:             2009-01-17 06:07 CST
Last Modified:              2009-01-20 16:31 CST
====================================================================== 
Summary:                    compilation warning for main/editline/history
Description: 
While building Asterisk I noticed:

history.c: In function 'history_def_add':
history.c:352: warning: implicit declaration of function 'strlcpy'
history.c:353: warning: implicit declaration of function 'strlcat'
   [CC] hash/hash.c -> hash/hash.o

I'm not sure if it affects anything but not having warnings during
compilation is definitely the Good Thing.
====================================================================== 

---------------------------------------------------------------------- 
 (0098267) jamesgolovich (manager) - 2009-01-20 16:31
 http://bugs.digium.com/view.php?id=14264#c98267 
---------------------------------------------------------------------- 
Is it worth adding another ifdef check when compat.h already does it:
#ifndef HAVE_STRLCAT
size_t strlcat(char *dst, const char *src, size_t siz);
#endif

#ifndef HAVE_STRLCPY
size_t strlcpy(char *dst, const char *src, size_t siz);
#endif

The editline lib that we use also brings their own compatibility
(main/editline/np/strlcpy.c + strlcat.c) to provide these but it looks like
the checks either don't exist in that configure script or they were
intentionally removed since asterisk provides or own 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-20 16:31 jamesgolovich  Note Added: 0098267                          
======================================================================