[asterisk-bugs] [Asterisk 0014264]: compilation warning for main/editline/history

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14264 
====================================================================== 
Reported By:                dimas
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14264
Category:                   General
Reproducibility:            have not tried
Severity:                   tweak
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 168729 
Request Review:              
====================================================================== 
Date Submitted:             2009-01-17 06:07 CST
Last Modified:              2009-01-20 16:26 CST
====================================================================== 
Summary:                    compilation warning for main/editline/history
Description: 
While building Asterisk I noticed:

history.c: In function 'history_def_add':
history.c:352: warning: implicit declaration of function 'strlcpy'
history.c:353: warning: implicit declaration of function 'strlcat'
   [CC] hash/hash.c -> hash/hash.o

I'm not sure if it affects anything but not having warnings during
compilation is definitely the Good Thing.
====================================================================== 

---------------------------------------------------------------------- 
 (0098265) putnopvut (administrator) - 2009-01-20 16:26
 http://bugs.digium.com/view.php?id=14264#c98265 
---------------------------------------------------------------------- 
jamesgolovich: I think that patch is all right except that we only need to
include asterisk.h if strlcpy and strlcat don't already exist on the
system. From what I understand, FreeBSD, Solaris, and Mac OS X already have
these functions available in system headers.

Asterisk's configure script checks for the existence of strlcpy and
strlcat. HAVE_STRLCPY and HAVE_STRLCAT will be defined if the functions are
already present on the system. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-20 16:26 putnopvut      Note Added: 0098265                          
======================================================================