[asterisk-bugs] [DAHDI-tools 0014103]: dahdi_monitor audio level meters are cut off halfway

[Asterisk Bug Tracker]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=14103 
====================================================================== 
Reported By:                gork
Assigned To:                seanbright
====================================================================== 
Project:                    DAHDI-tools
Issue ID:                   14103
Category:                   General
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             2008-12-17 17:54 CST
Last Modified:              2009-01-13 17:46 CST
====================================================================== 
Summary:                    dahdi_monitor audio level meters are cut off halfway
Description: 
In the current dahdi-tools packages, the audio level meters are cut off due
to the way the string is built up in draw_barheader().

They look like this:

<----------------(RX <----------------(TX

When they should look like this:

<----------------(RX)---------------->
<----------------(TX)---------------->
====================================================================== 

---------------------------------------------------------------------- 
 (0097683) svnbot (reporter) - 2009-01-13 17:46
 http://bugs.digium.com/view.php?id=14103#c97683 
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 5656

U   tools/trunk/dahdi_monitor.c

------------------------------------------------------------------------
r5656 | seanbright | 2009-01-13 17:46:01 -0600 (Tue, 13 Jan 2009) | 8
lines

The problem with using dahdi_copy_string here is that it is guaranteed to
NULL
terminate the destination string, which in this case was not correct.  So
revert
back to using strncpy and also decrease the buffer by 1 since it was
reserving
an extra byte behind NULL for some reason.  Fix suggested by reporter.

(closes issue http://bugs.digium.com/view.php?id=14103)
Reported by: gork

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=5656 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-13 17:46 svnbot         Checkin                                      
2009-01-13 17:46 svnbot         Note Added: 0097683                          
2009-01-13 17:46 svnbot         Status                   new => assigned     
2009-01-13 17:46 svnbot         Assigned To               => seanbright      
======================================================================