[asterisk-bugs] [Asterisk 0014176]: [patch] send out the incorrect register request URI to the (fromdomain) outbound proxy

Tue Jan 13 16:31:21 CST 2009

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14176 
====================================================================== 
Reported By:                paraeco
Assigned To:                otherwiseguy
====================================================================== 
Project:                    Asterisk
Issue ID:                   14176
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.22 
Regression:                 Yes 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 126902 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-01-05 21:31 CST
Last Modified:              2009-01-13 16:31 CST
====================================================================== 
Summary:                    [patch] send out the incorrect register request URI
to the (fromdomain) outbound proxy
Description: 
It is actually reopening the issue http://bugs.digium.com/view.php?id=12474 .
A bug is introduced into the file channel/chan_sip.c in the asterisk 1.4
branch -- SVN revision http://bugs.digium.com/view.php?id=126902.

ast_string_field_set(p, fromdomain, ++fromdomain);

In the above code, ++fromdomain would be executed twice in the macro
ast_string_field_set() .
It results in the first character of the domain name to be eliminated .
A fix is included in the additional information filed .

Edit: the fix has been removed as all patch submissions MUST be posted to
the tracker correctly; not inline.

====================================================================== 

---------------------------------------------------------------------- 
 (0097663) svnbot (reporter) - 2009-01-13 16:31
 http://bugs.digium.com/view.php?id=14176#c97663 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 168580

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r168580 | twilson | 2009-01-13 16:31:21 -0600 (Tue, 13 Jan 2009) | 21
lines

Merged revisions 168578 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r168578 | twilson | 2009-01-13 16:22:34 -0600 (Tue, 13 Jan 2009) | 14
lines

  Merged revisions 168551 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4

  ........
    r168551 | twilson | 2009-01-13 12:34:14 -0600 (Tue, 13 Jan 2009) | 7
lines

    Don't pass a value with a side effect to a macro

    (closes issue http://bugs.digium.com/view.php?id=14176)
    Reported by: paraeco
    Patches: 
          chan_sip.c.diff uploaded by paraeco (license 658)
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=168580 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-13 16:31 svnbot         Checkin                                      
2009-01-13 16:31 svnbot         Note Added: 0097663                          
======================================================================