[asterisk-bugs] [Asterisk 0013786]: [patch] DAHDI_CHECK_HOOKSTATE automatically defined when chan_dahdi is built with zaptel support

[Asterisk Bug Tracker]

The following issue has been CLOSED 
====================================================================== 
http://bugs.digium.com/view.php?id=13786 
====================================================================== 
Reported By:                tzafrir
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   13786
Category:                   Channels/chan_dahdi
Reproducibility:            always
Severity:                   major
Priority:                   high
Status:                     closed
Target Version:             1.6.0.4
Asterisk Version:           SVN 
Regression:                 Yes 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 151905 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2008-10-26 06:15 CDT
Last Modified:              2009-01-12 14:33 CST
====================================================================== 
Summary:                    [patch] DAHDI_CHECK_HOOKSTATE automatically defined
when chan_dahdi is built with zaptel support
Description: 
chan_dahdi.c has the following compile time option:

/*! \note
 * Define if you want to check the hook state for an FXO (FXS signalled)
interface
 * before dialing on it.  Certain FXO interfaces always think they're out
of
 * service with this method however.
 */
/* #define DAHDI_CHECK_HOOKSTATE */

Sadly, DAHDI_CHECK_HOOKSTATE is defined unconditionally in
include/asterisk/dahdi_compat.h in case you built it with zaptel support:

#define DAHDI_CHECK_HOOKSTATE ZT_CHECK_HOOKSTATE

Thus it should be made conditioned on the definition of
ZT_CHECK_HOOKSTATE, just in case someone had it in a build script.

At first glance it seems that the same applies to:

#ifdef DAHDI_EVENT_EC_DISABLED
#ifdef DAHDI_EVENT_RINGBEGIN
#ifdef DAHDI_GETCONFMUTE
#ifdef DAHDI_PRI
#ifdef DAHDI_TONEDETECT

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0013927 Unable to Dial() through FXO port until...
related to          0013890 x100p modem no longer functions in 1.5 ...
====================================================================== 

---------------------------------------------------------------------- 
 (0097522) tzafrir (manager) - 2009-01-12 14:33
 http://bugs.digium.com/view.php?id=13786#c97522 
---------------------------------------------------------------------- 
Already fixed before 1.6.0-rc3, indeed.

My mistake. I'm not sure at which copy of chan_dahdi.c I looked yesterday
that seemed unfixed. Sorry for the noise. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-01-12 14:33 tzafrir        Note Added: 0097522                          
2009-01-12 14:33 tzafrir        Status                   assigned => closed  
2009-01-12 14:33 tzafrir        Resolution               reopened => fixed   
======================================================================