[asterisk-bugs] [Asterisk 0010297]: [patch] Unload/load support for chan_skinny

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10297 
====================================================================== 
Reported By:                DEA
Assigned To:                mvanbaak
====================================================================== 
Project:                    Asterisk
Issue ID:                   10297
Category:                   Channels/chan_skinny/NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.6.0-beta8 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 76940 
Request Review:              
====================================================================== 
Date Submitted:             2007-07-25 01:40 CDT
Last Modified:              2009-02-27 14:34 CST
====================================================================== 
Summary:                    [patch] Unload/load support for chan_skinny
Description: 
Reload is not working, but unload and load do work.
My reload code is ugly-simple, it calls the unload 
function, then the load function.  I would have thought
if I could manually unload and load that would be enough.


My threading knowledge is more than a bit weak, but the
existing code was 90% there already.  We needed to store
the address of the skinny_session thread launch from within
accept_thread so we could later cancel it.

Interestingly the skinnysession structure had a member to
store the thread address, but it did not appear to be used.

I also move the teardown of the accept thread to a point before
tearing down the sessions (and their threads) to prevent a phone
from trying to re-register and recreating a session thread after
we had processed it.


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013524 [patch] Fixes skinny unload
====================================================================== 

---------------------------------------------------------------------- 
 (0100905) svnbot (reporter) - 2009-02-27 14:34
 http://bugs.digium.com/view.php?id=10297#c100905 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 179122

U   trunk/channels/chan_skinny.c

------------------------------------------------------------------------
r179122 | mvanbaak | 2009-02-27 14:34:00 -0600 (Fri, 27 Feb 2009) | 16
lines

Add reload support to chan_skinny.

Special thanks goes to DEA who had to redo this patch twice
because we first put unload/load support in and later redid the way
we configure devices and lines.

(closes issue http://bugs.digium.com/view.php?id=10297)
Reported by: DEA
Patches:
      skinny-reload-trunkv2.diff uploaded by wedhorn (license 30)
      skinny-reload-trunk-v4.txt uploaded by DEA (license 3)
	  With mods by me based on feedback from wedhorn and Russell and
seanbright
Tested by: DEA, mvanbaak, pj

Review: http://reviewboard.digium.com/r/130/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=179122 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-27 14:34 svnbot         Checkin                                      
2009-02-27 14:34 svnbot         Note Added: 0100905                          
======================================================================