[asterisk-bugs] [Asterisk 0014515]: [patch]Timeout settings in features.conf don't work as intended

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14515 
====================================================================== 
Reported By:                sodom
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   14515
Category:                   Resources/res_features
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.23 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-02-20 04:59 CST
Last Modified:              2009-02-26 11:09 CST
====================================================================== 
Summary:                    [patch]Timeout settings in features.conf don't work
as intended
Description: 
It seems that some of the feature.conf settings didn't work as intendet, at
least for the misdn channel.

a) I changed the code for disconnect from "*0" to "*0#" but asterisk still
disconnects with the code *0 (feature show, shows me that it is successfuly
changed to *0#)
b) I changed the timeout for featuresdigits from 500ms to 1000ms but as it
seem the timeout is not on a didgit base it's for the complete command. If
i did't finish the complete feature dial string in this time, the feature
isn't activated. (All fetures were changed to three digit numbers on our
side.)
c) I changed the timeout for transferdigit from 3 secs to 15sec as it has
the same issue as b) if i don't complete the number in the configured time,
the transfer is interrupted.
====================================================================== 

---------------------------------------------------------------------- 
 (0100805) svnbot (reporter) - 2009-02-26 11:09
 http://bugs.digium.com/view.php?id=14515#c100805 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 178804

U   branches/1.4/res/res_features.c

------------------------------------------------------------------------
r178804 | murf | 2009-02-26 11:09:04 -0600 (Thu, 26 Feb 2009) | 28 lines

This patch prevents the feature detection timeout from being cut in half.

Because the ast_channel_bridge() call will return 0 and pass
a frame pointer for both DTMF_BEGIN and DTMF_END, the feature_timer
field in hte config struct is getting decremented twice, which 
effectively cuts the digittimeout in half. I added conditions
to the if statement to only let DTMF_END frames to flow thru,
which solved the problem. Also, when the frame pointer is null,
let control flow thru-- this usually happens on timeouts. I added
a comment to the code to explain what's going on and why.

Many thanks to sodom for reporting this problem. Personnally, it always
seemed
like something was wrong with the featuredigittimeout, but I never
could quite decide what... and was too busy to investigate.
This bug forced the issue, and now we know.

Sodom had other issues in 14515, but I couldn't reproduce them. If
he still has problems, and wants to get them solved, he is welcome
to reopen 14515.


(closes issue http://bugs.digium.com/view.php?id=14515)
Reported by: sodom
Patches:
      14515.patch uploaded by murf (license 17)
Tested by: murf, sodom


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=178804 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-26 11:09 svnbot         Checkin                                      
2009-02-26 11:09 svnbot         Note Added: 0100805                          
======================================================================