[asterisk-bugs] [DAHDI-linux 0013897]: [patch] Support for generic HFC-4S cards

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13897 
====================================================================== 
Reported By:                tzafrir
Assigned To:                tzafrir
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   13897
Category:                   wcb4xxp
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     confirmed
====================================================================== 
Date Submitted:             2008-11-13 16:17 CST
Last Modified:              2009-02-24 13:02 CST
====================================================================== 
Summary:                    [patch] Support for generic HFC-4S cards
Description: 
A patch to add some basic support of other HFC-4S -based PCI cards (such as
the ones made by Junghanns). 

Status: gets rid of the echo canceller messages when not needed, but still
needs work.

Specifically:
* It adds too broad a range of cards (which also include bero.net cards) 
* The range may include some 2-ports cards, which will probably not work.

Not yet tested to work, though it it is at least configured.

====================================================================== 

---------------------------------------------------------------------- 
 (0100652) tzafrir (manager) - 2009-02-24 13:02
 http://bugs.digium.com/view.php?id=13897#c100652 
---------------------------------------------------------------------- 
zhulizhong, I'm reformatting the patch a bit. Generally looks good. One
small thing:

In b4xxp_update_leds_HFC() (I preffered renaming it
b4xxp_update_leds_hfc() to comply with naming conventions) you have a
number of wrongly-indented if-s:

+			if (bspan->span.alarms) {
+				if (b4->blinktimer == (led_fader_table[b4->alarmpos] >> 1))
+					led[i] = 2;
+					lled |= 0 << i;

"lled |= 0 << i;" will be run regardless of the condition. And this goes
on:

+				if (b4->blinktimer == 0xf)
+					led[i] = 0;
+					lled |= 1 << i;
+			} else if (bspan->span.mainttimer || bspan->span.maintstat) {
+				if (b4->blinktimer == (led_fader_table[b4->alarmpos] >> 1))
+					led[i] = 1;
+					lled |= 0 << i;
+				if (b4->blinktimer == 0xf)
+					led[i] = 0;
+					lled |= 1 << i;

But unlike:

+			} else {
+				/* No Alarm */
+				led[i] = 1;
+				lled |= 0 << i;
+			}

Considering i is not necessarily a single bit, I'm not sure exactly what
this code does. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-24 13:02 tzafrir        Note Added: 0100652                          
======================================================================