[asterisk-bugs] [Asterisk 0013371]: [patch] Outgoing notification hints not functioning for SIP type=friend

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13371 
====================================================================== 
Reported By:                minufi
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13371
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.21.2 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2008-08-25 05:20 CDT
Last Modified:              2009-02-21 12:51 CST
====================================================================== 
Summary:                    [patch] Outgoing notification hints not functioning
for SIP type=friend
Description: 
When having a SIP device configured as type friend, outgoing calls are not
notified via hints. Only incoming calls are notified correctly.
With type peer outgoing calls are notified.

I think in chan_sip.c line 3220-3229 the inUse state isn´t set correct.
With type peer, inuse is set in line 3225.
If you´re using type friend, inuse is set in line 3221.

====================================================================== 

---------------------------------------------------------------------- 
 (0100513) minufi (reporter) - 2009-02-21 12:51
 http://bugs.digium.com/view.php?id=13371#c100513 
---------------------------------------------------------------------- 
I have tested the issue with version 1.4.21.2, 1.4.22 and 1.4.23.1. The
behaviour is still the same.

I have made a workaround for my comfiguration for version 1.4.23.1.
In line 3261 (chan_sip.c) I changed the following:
- if (global_limitonpeers == FALSE && !outgoing && (u = find_user(name,
1)))  {

+	p = find_peer(ast_strlen_zero(fup->peername) ? name : fup->peername,
NULL, 1, 0);
+	
+	if (global_limitonpeers == FALSE && !outgoing && (u = find_user(name,
1)) && p==NULL)  {

With this change the outgoing call is notified correctly.

I have append my minimal comfiguration files.
I hope now, you can reproduce the behaviour. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-21 12:51 minufi         Note Added: 0100513                          
======================================================================