[asterisk-bugs] [Asterisk 0014305]: pbx.c's show_dialplan_helper prints an "\r\n" at the end of every call

Fri Feb 20 17:05:12 CST 2009

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14305 
====================================================================== 
Reported By:                martins
Assigned To:                svnbot
====================================================================== 
Project:                    Asterisk
Issue ID:                   14305
Category:                   Core/PBX
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 169943 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-01-21 20:21 CST
Last Modified:              2009-02-20 17:05 CST
====================================================================== 
Summary:                    pbx.c's show_dialplan_helper prints an "\r\n" at the
end of every call
Description: 
Asterisk-Java has expected to consistently see any Manager responses of the
"response: Follows" style to contain whatever response in a single
"\r\n"-ending line somewhere in the response, which could contain multiple
"\n", but ends in "--END COMMAND--\r\n". We've had much success with this
consistent behavior. In fact, it's one of the only ways we can recognize
the data lines that come with a command (because they aren't delimited with
"\r\n", but only an "\n").

Doing an "action: Command" with "dialplan show" as the command fails this
expectation. See additional information for more.
====================================================================== 

---------------------------------------------------------------------- 
 (0100484) svnbot (reporter) - 2009-02-20 17:05
 http://bugs.digium.com/view.php?id=14305#c100484 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 177789

_U  branches/1.6.1/
U   branches/1.6.1/main/pbx.c

------------------------------------------------------------------------
r177789 | tilghman | 2009-02-20 17:05:12 -0600 (Fri, 20 Feb 2009) | 23
lines

Merged revisions 177787 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r177787 | tilghman | 2009-02-20 17:02:35 -0600 (Fri, 20 Feb 2009) | 16
lines

  Merged revisions 177786 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4

  ........
    r177786 | tilghman | 2009-02-20 16:59:52 -0600 (Fri, 20 Feb 2009) | 9
lines

    Don't print the CR-NL combination when we aren't outputting to the
manager.

    An embedded CR-NL in a CLI command screws up several AMI parsers that
don't
    expect to see that combination in the middle of output.

    (Closes issue http://bugs.digium.com/view.php?id=14305)
    Reported by: martins
    Patch by: tilghman
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=177789 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-20 17:05 svnbot         Checkin                                      
2009-02-20 17:05 svnbot         Note Added: 0100484                          
======================================================================