[asterisk-bugs] [Asterisk 0012761]: [patch] chan_sip: build_contact() does not put alternate port setting in Contact header

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12761 
====================================================================== 
Reported By:                asbestoshead
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   12761
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 118255 
Request Review:              
====================================================================== 
Date Submitted:             2008-05-30 03:04 CDT
Last Modified:              2009-02-18 18:46 CST
====================================================================== 
Summary:                    [patch] chan_sip: build_contact() does not put
alternate port setting in Contact header
Description: 
build_contact() looks at the *other* end's port to decide whether there's a
non-standard port in use. If my end has bindport=5062 but the peer has
port=5060, when I send an invite to the peer, my Contact header doesn't
have ":5062".

initreqprep() has the same problem when setting the From: header.

chan_sip in Asterisk trunk and 1.6.0-beta8 (but not 1.4.19) have this
problem.

I have a trivial patch for this against Moy's mfcr2 branch off trunk, but
I can't find the link to sign the contributor's agreement. The patch also
applies to 1.6.0beta8, although I haven't tested it there...
====================================================================== 

---------------------------------------------------------------------- 
 (0100352) jcovert (reporter) - 2009-02-18 18:46
 http://bugs.digium.com/view.php?id=12761#c100352 
---------------------------------------------------------------------- 
Thank you asbestoshead.  I've just applied your patch to 1.6.0.3 to solve a
problem I had been avoiding, but could avoid no longer.  Works great.

/john 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-18 18:46 jcovert        Note Added: 0100352                          
======================================================================