[asterisk-bugs] [Asterisk 0014461]: [patch] func_devstate not updating Custom hints, and not in sync with ASTDB

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14461 
====================================================================== 
Reported By:                alecdavis
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   14461
Category:                   Functions/func_devstate
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Target Version:             1.6.1
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 174327 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-02-11 22:53 CST
Last Modified:              2009-02-17 11:38 CST
====================================================================== 
Summary:                    [patch] func_devstate not updating Custom hints, and
not in sync with ASTDB
Description: 
astdb is always being updated, but sometimes hints are not.
It's not consistant, as I type this bug, it will come right and work
correctly for a while, then go wrong.

astrid*CLI> database show CustomDevstate
...
/CustomDevstate/q8501_a8512                       : INUSE
...

astrid*CLI> core show hints
            8501GXP0001 at BLF_Group_1         : Custom:q8501_a8512   
State:Idle            Watchers  1

further manipulation from the command line.

astrid*CLI> devstate change Custom:q8501_a8512 NOT_INUSE
Changing q8501_a8512 to NOT_INUSE
  == Extension Changed 8501GXP0001[BLF_Group_1] new state InUse for Notify
User GXP0001

astrid*CLI> devstate change Custom:q8501_a8512 INUSE
Changing q8501_a8512 to INUSE
  == Extension Changed 8501GXP0001[BLF_Group_1] new state Idle for Notify
User GXP0001

But the weirdest thing, the BLF lamp on the phone comes right after approx
35 seconds, but still the Hint is incorrect.



====================================================================== 

---------------------------------------------------------------------- 
 (0100259) svnbot (reporter) - 2009-02-17 11:38
 http://bugs.digium.com/view.php?id=14461#c100259 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 176559

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_queue.c
U   branches/1.6.1/main/pbx.c

------------------------------------------------------------------------
r176559 | russell | 2009-02-17 11:38:47 -0600 (Tue, 17 Feb 2009) | 20
lines

Merged revisions 176557 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
r176557 | russell | 2009-02-17 11:33:38 -0600 (Tue, 17 Feb 2009) | 12
lines

Fix a race condition that caused device states to become incorrect for
hints.

The problem here is that the hint processing code was subscribed to the
wrong
event type.  So, it started processing state for a hint too soon, before
the
device state cache had been updated.

Also, fix a similar bug in app_queue, as it was also subscribed to the
wrong
event type.

(closes issue http://bugs.digium.com/view.php?id=14461)
Reported by: alecdavis

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=176559 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-17 11:38 svnbot         Checkin                                      
2009-02-17 11:38 svnbot         Note Added: 0100259                          
======================================================================