[asterisk-bugs] [Asterisk 0014364]: NULL file descriptors causing GUI to eventually stop functioning

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14364 
====================================================================== 
Reported By:                awk
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   14364
Category:                   Core/ManagerInterface
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     ready for review
Target Version:             1.6.0.6
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 171686 
Request Review:              
====================================================================== 
Date Submitted:             2009-01-29 09:17 CST
Last Modified:              2009-02-10 15:45 CST
====================================================================== 
Summary:                    NULL file descriptors causing GUI to eventually stop
functioning
Description: 
I'm having an issue where file descriptors for GUI manager sessions are
NULL, and after a period of time (24 hrs possibly), the GUI stops
functioning as it can no longer open config files (see below).

fd == -1 in astman_append, should not happen
fd == -1 in astman_append, should not happen
fd == -1 in astman_append, should not happen
  == HTTP Manager 'admin' timed out from 127.0.0.1
  == HTTP Manager 'admin' logged on from 127.0.0.1
  == Parsing '/etc/asterisk/http.conf':   == Not found (Too many open
files)
  == Parsing '/etc/asterisk/http.conf':   == Not found (Too many open
files)
  == Parsing '/etc/asterisk/http.conf':   == Not found (Too many open
files)

I'm not exactly sure what other info will be useful as Asterisk doesn't
crash or deadlock. I haven't checked yet to see if this happens in 1.6.1.
It doesn't appear to happen in my 1.4 install.

====================================================================== 

---------------------------------------------------------------------- 
 (0099853) svnbot (reporter) - 2009-02-10 15:45
 http://bugs.digium.com/view.php?id=14364#c99853 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 174764

U   trunk/main/manager.c

------------------------------------------------------------------------
r174764 | mmichelson | 2009-02-10 15:45:14 -0600 (Tue, 10 Feb 2009) | 21
lines

Fix an fd leak that would occur in HTTP AMI sessions

The explanation behind this fix is a bit complicated, and I've already
typed it up in the code as a huge comment inside of manager.c, so I'll
give the abridged version here.

We needed a way to separate action-specific data from session-specific
data.
Unfortunately, the only way to maintain API compatibility and to not have
to
change every single manager action was to rename the current mansession
structure
and wrap it inside a new mansession structure which actually contains
action-
specific data.

(closes issue http://bugs.digium.com/view.php?id=14364)
Reported by: awk
Patches:
      14364_better.patch uploaded by putnopvut (license 60)
Tested by: putnopvut

Review: http://reviewboard.digium.com/r/148/


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=174764 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-10 15:45 svnbot         Note Added: 0099853                          
======================================================================