[asterisk-bugs] [Asterisk 0013238]: False state in core show hints

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13238 
====================================================================== 
Reported By:                kowalma
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13238
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            random
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.0-beta9 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2008-08-05 07:45 CDT
Last Modified:              2009-02-10 14:12 CST
====================================================================== 
Summary:                    False state in core show hints
Description: 
core show hint shows false value of dev state:

asterisk-IBM*CLI> core show hint 1231
                   1231 at hints               : SIP/1231             
State:InUse           Watchers  0
1 hint matching extension 1231


asterisk-IBM:/usr/src# rasterisk -x "core show channels" | grep 1231
asterisk-IBM:/usr/src#

asterisk-IBM:/usr/src# rasterisk -x "sip show channels" | grep 1231

SIP/1231 is asterisk 1.4.19, asterisk IBM (where I do core show hints) is
1.6.beta9

Restarting asterisk on 1231 does not solve the problem. 
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013935 Calls are not beeing disconnected
====================================================================== 

---------------------------------------------------------------------- 
 (0099839) alecdavis (reporter) - 2009-02-10 14:12
 http://bugs.digium.com/view.php?id=13238#c99839 
---------------------------------------------------------------------- 
As I only upgraded to trunk yesterday, and no patches uploaded, I've just
manually applied the changes, from viewing diffs from
http://svn.digium.com/view/asterisk?view=rev&revision=174543

Shouldn't the same checking be applied to the following, to only allow
decrementing of inringing if it's positive. 

line 5315 of chan_sip.c

        case DEC_CALL_RINGING:
                if (inringing) {
                        sip_pvt_lock(fup);
                        ao2_lock(p);
                        if (ast_test_flag(&fup->flags[0],
SIP_INC_RINGING)) {
                                (*inringing)--;
                                ast_clear_flag(&fup->flags[0],
SIP_INC_RINGING);
                        }
                        ao2_unlock(p);
                        sip_pvt_unlock(fup);
                } 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-10 14:12 alecdavis      Note Added: 0099839                          
======================================================================