[asterisk-bugs] [Asterisk 0013602]: [patch] Bad handling of Contact header, which should not be present in 1XX responses to REGISTER, but also in several other case

Fri Feb 6 10:39:22 CST 2009

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13602 
====================================================================== 
Reported By:                hjourdain
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   13602
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.22 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2008-10-02 07:42 CDT
Last Modified:              2009-02-06 10:39 CST
====================================================================== 
Summary:                    [patch] Bad handling of Contact header, which should
not be present in 1XX responses to REGISTER, but also in several other case
Description: 
When Asterisk sends a response to a UA, the algorithm to include the
Contact header that's use in resprep is flawed.
This leads to sending the contact header in 100 Trying responses to
REGISTER.
But this is also true in many other cases, depending on the type of
response (1xx, 2xx, 3xx 485 or other) and the type of request.
====================================================================== 

---------------------------------------------------------------------- 
 (0099617) svnbot (reporter) - 2009-02-06 10:39
 http://bugs.digium.com/view.php?id=13602#c99617 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 173964

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c
U   branches/1.6.1/main/ast_expr2.c
U   branches/1.6.1/main/ast_expr2.h

------------------------------------------------------------------------
r173964 | mnicholson | 2009-02-06 10:39:22 -0600 (Fri, 06 Feb 2009) | 21
lines

Merged revisions 173952 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r173952 | mnicholson | 2009-02-06 10:28:19 -0600 (Fri, 06 Feb 2009) | 14
lines

  Merged revisions 173917 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4

  ........
    r173917 | mnicholson | 2009-02-06 10:20:23 -0600 (Fri, 06 Feb 2009) |
7 lines

    Limit the addition of the Contact header in SIP responses according to
various
    SIP RFCs.

    (closes issue http://bugs.digium.com/view.php?id=13602)
    Reported by: hjourdain
    Tested by: mnicholson
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=173964 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-06 10:39 svnbot         Checkin                                      
2009-02-06 10:39 svnbot         Note Added: 0099617                          
======================================================================