[asterisk-bugs] [Asterisk 0014352]: [patch] Adding JabberJoin and an argument to JabberSend for groupchats

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14352 
====================================================================== 
Reported By:                fiddur
Assigned To:                phsultan
====================================================================== 
Project:                    Asterisk
Issue ID:                   14352
Category:                   Resources/res_jabber
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 171829 
Request Review:              
====================================================================== 
Date Submitted:             2009-01-28 04:39 CST
Last Modified:              2009-02-06 09:30 CST
====================================================================== 
Summary:                    [patch] Adding JabberJoin and an argument to
JabberSend for groupchats
Description: 
Joining groupchats already has functions in res_jabber.c, they are just not
available from the dialplan.

I added JabberJoin and a parameter to JabberSend to say if it is to a
groupchat.  
====================================================================== 

---------------------------------------------------------------------- 
 (0099601) phsultan (manager) - 2009-02-06 09:30
 http://bugs.digium.com/view.php?id=14352#c99601 
---------------------------------------------------------------------- 
Hi fiddur, thanks a lot for implementing this. I had some code that
addresses this feature, which implements JabberJoin (and allows to choose a
nickname for the chatroom) and JabberLeave. I attached the patch, that
applies to trunk since it's a new feature.

Regarding JabberSend, I found it clearer to write a new application
(JabberSendGroup) that explicitly sends group messages.

In the attached patch, Asterisk (when connected as a component) can send
messages to a chatroom using the provided (optional) nickname. As an
example, suppose you connected Asterisk as a component named 'asterisk' to
your XMPP server, you could :
- enter any chat room with any nickname ;
- send messages from any nickname to any chat room.

If you connect Asterisk as a regular XMPP client, messages sent to chat
rooms will be seen as coming from the nickname you chose when joining the
corresponding chat room.

Can you please give your feedback on it? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-06 09:30 phsultan       Note Added: 0099601                          
======================================================================