[asterisk-bugs] [Asterisk 0014227]: queue-thankyou should be played only if needed

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14227 
====================================================================== 
Reported By:                caspy
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   14227
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
Target Version:             1.6.2
Asterisk Version:           1.6.0.3-rc1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-13 07:27 CST
Last Modified:              2009-02-03 11:16 CST
====================================================================== 
Summary:                    queue-thankyou should be played only if needed
Description: 
In say_position() in app_queue.c there is a command to play
'queue-thankyou' sound:
  res = play_file(qe->chan, qe->parent->sound_thanks);

This sound is played unconditionally, but should be played only in case if
position or holdtime was played.
Current code is generating 'queue-thankyou' without anything else, for
example, in case of position turned off + holdtime turned on, and hold time
less than a 1 minute.
====================================================================== 

---------------------------------------------------------------------- 
 (0099352) caspy (reporter) - 2009-02-03 11:16
 http://bugs.digium.com/view.php?id=14227#c99352 
---------------------------------------------------------------------- 
Hmm...

I did not tried 14227_v2.patch, but i think this is completly what we do
not want.
Look,
- if you turn on announcement of position and holdtime together, 'thank
you' will be played twice one by one.
- if you set to announce holdtime and holdtime == 0, 'thank you' still
will be played.
- this breaks yours idea to play 'thank you' when both position and
holdtime turned off (i mean idea about 'your call is important for us').


Please, look once again for my previous suggestion. It is more expectable
in its behavior for any user. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-03 11:16 caspy          Note Added: 0099352                          
======================================================================