[asterisk-bugs] [Asterisk 0014227]: queue-thankyou should be played only if needed

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14227 
====================================================================== 
Reported By:                caspy
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   14227
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
Target Version:             1.6.2
Asterisk Version:           1.6.0.3-rc1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-13 07:27 CST
Last Modified:              2009-02-03 10:35 CST
====================================================================== 
Summary:                    queue-thankyou should be played only if needed
Description: 
In say_position() in app_queue.c there is a command to play
'queue-thankyou' sound:
  res = play_file(qe->chan, qe->parent->sound_thanks);

This sound is played unconditionally, but should be played only in case if
position or holdtime was played.
Current code is generating 'queue-thankyou' without anything else, for
example, in case of position turned off + holdtime turned on, and hold time
less than a 1 minute.
====================================================================== 

---------------------------------------------------------------------- 
 (0099343) putnopvut (administrator) - 2009-02-03 10:35
 http://bugs.digium.com/view.php?id=14227#c99343 
---------------------------------------------------------------------- 
I have uploaded a new patch, 14227_v2.patch which has everything from
14227.patch, plus now the queue-thankyou sound will only play if holdtime
was announced or if the position in the queue was announced to the caller.

You'll notice I didn't do this exactly as you described because for one
thing, I wanted to still play the sound for position announcements, and
there's already a block of code that executes for holdtime announcements,
so I placed the queue-thankyou sound playback there.

Let me know how it works for you! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-03 10:35 putnopvut      Note Added: 0099343                          
======================================================================