[asterisk-bugs] [Asterisk 0014227]: queue-thankyou should be played only if needed

[Asterisk Bug Tracker]

The following issue is now READY FOR TESTING. 
====================================================================== 
http://bugs.digium.com/view.php?id=14227 
====================================================================== 
Reported By:                caspy
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   14227
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
Target Version:             1.6.2
Asterisk Version:           1.6.0.3-rc1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-13 07:27 CST
Last Modified:              2009-02-02 16:09 CST
====================================================================== 
Summary:                    queue-thankyou should be played only if needed
Description: 
In say_position() in app_queue.c there is a command to play
'queue-thankyou' sound:
  res = play_file(qe->chan, qe->parent->sound_thanks);

This sound is played unconditionally, but should be played only in case if
position or holdtime was played.
Current code is generating 'queue-thankyou' without anything else, for
example, in case of position turned off + holdtime turned on, and hold time
less than a 1 minute.
====================================================================== 

---------------------------------------------------------------------- 
 (0099285) putnopvut (administrator) - 2009-02-02 16:09
 http://bugs.digium.com/view.php?id=14227#c99285 
---------------------------------------------------------------------- 
I've uploaded 14227.patch. This contains

* An explicit check in app_queue's play_file function to return early if
attempting to play a file whose name is zero-length

* A change to the comparison of avgholdmins in the say_announcement
function so that hold times between 1 minute and 2 minutes may be
reported.

* A change to the queues.conf.sample file which makes it clear that you
may disable a sound from being played by specifying a zero-length value for
the option.

Give it a test to be sure it does what you want and let me know if you
think the update to queues.conf.sample is clear enough. Thanks! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-02 16:09 putnopvut      Note Added: 0099285                          
2009-02-02 16:09 putnopvut      Status                   assigned => ready for
testing
======================================================================