[asterisk-bugs] [Asterisk 0014227]: queue-thankyou should be played only if needed

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14227 
====================================================================== 
Reported By:                caspy
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   14227
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     assigned
Target Version:             1.6.2
Asterisk Version:           1.6.0.3-rc1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-13 07:27 CST
Last Modified:              2009-02-02 15:18 CST
====================================================================== 
Summary:                    queue-thankyou should be played only if needed
Description: 
In say_position() in app_queue.c there is a command to play
'queue-thankyou' sound:
  res = play_file(qe->chan, qe->parent->sound_thanks);

This sound is played unconditionally, but should be played only in case if
position or holdtime was played.
Current code is generating 'queue-thankyou' without anything else, for
example, in case of position turned off + holdtime turned on, and hold time
less than a 1 minute.
====================================================================== 

---------------------------------------------------------------------- 
 (0099272) putnopvut (administrator) - 2009-02-02 15:18
 http://bugs.digium.com/view.php?id=14227#c99272 
---------------------------------------------------------------------- 
This is one of those issues where I need to be careful not to be disruptive
with a behavioral change.

I can certainly understand caspy's point about having what is seemingly an
out-of-place "Thank you for your patience" message play when not announcing
a hold time or position. I also have to keep in mind that this prompt is
completely configurable from within queues.conf. It is quite possible that
administrators count on a file to always play and say something like "Thank
you for calling. Your call is important to us and we will be with you as
shortly as possible" instead of the default sound.

Now, as I mentioned, the queues.conf file can be configured to play
whatever sound it is that you want for queue-thankyou. The default is to
use the sound of the same name, but you can actually specify tt-weasels or
one of your own home-rolled files if you want. What this also means is that
you can set it as

queue-thankyou=

This explicitly tells the queue application not to play a sound when it
wants to play queue-thankyou. With the current state of the code, this will
work and there will be no adverse consequences from doing so, but you will
see warnings on the CLI because the file '' will not be able to be played
when app_queue tries to play queue-thankyou.

I will attach a patch here which will make it so that app_queue will only
try to play the queue-thankyou sound if the sound that it should be playing
is not a zero-length string. I'll also add a note to the queues.conf.sample
file noting that if you wish to not play a specific sound, you can do so as
I showed above by setting the option to a zero-length argument.

Your note in the additional information about when the minute is singular
is absolutely right and I will include an update for that logic in the
patch I upload. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-02 15:18 putnopvut      Note Added: 0099272                          
======================================================================