[asterisk-bugs] [Asterisk 0016168]: Hold Time report (reportholdtime) issue

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16168 
====================================================================== 
Reported By:                nickilo
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   16168
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.1.5 
JIRA:                       SWP-466 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-11-02 17:23 CST
Last Modified:              2009-12-23 16:48 CST
====================================================================== 
Summary:                    Hold Time report (reportholdtime) issue
Description: 
When reporting hold time, 

the number of second has to be modulo 60 otherwise the announce can be :
2 minutes 123 seconds instead of 2 minutes 3 seconds

Additionnally the file queue-minute does not exist.

I hope i'm clear enough.

I propose to do the following changes to /apps/app_queue.c :

at line 4187 : change holdtimesecs = abs((now - qe->start)); TO
holdtimesecs = abs((now - qe->start)%60);

at line 4190 : change play_file(peer, qe->parent->sound_minute); TO
play_file(peer, qe->parent->sound_minutes);


Thank You

====================================================================== 

---------------------------------------------------------------------- 
 (0115754) dvossel (administrator) - 2009-12-23 16:48
 https://issues.asterisk.org/view.php?id=16168#c115754 
---------------------------------------------------------------------- 
The patch looks great, I'm concerned about the fact that the minute sound
is missing.  I'm going to investigate this before merging your fix.  Thanks
for the contribution. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-23 16:48 dvossel        Note Added: 0115754                          
======================================================================