[asterisk-bugs] [Asterisk 0016318]: [patch] New SDP handling code totally broke T.38 reinvites

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16318 
====================================================================== 
Reported By:                bird_of_Luck
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   16318
Category:                   Channels/chan_sip/T.38
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.27 
JIRA:                       SWP-594 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-11-24 08:52 CST
Last Modified:              2009-12-23 09:46 CST
====================================================================== 
Summary:                    [patch] New SDP handling code totally broke T.38
reinvites
Description: 
SDP handling code introduced in r227758 effectively sets t38jointcapability
to 0 causing reinvite to fail with reason 'No compatible codecs, not
accepting this offer!'
====================================================================== 

---------------------------------------------------------------------- 
 (0115728) svnbot (reporter) - 2009-12-23 09:46
 https://issues.asterisk.org/view.php?id=16318#c115728 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 236261

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r236261 | mnicholson | 2009-12-23 09:21:28 -0600 (Wed, 23 Dec 2009) | 8
lines

Properly set T.38 attributes and don't return before T.38 ports are
configured when T.38 is found but no audio stream is found.

(closes issue https://issues.asterisk.org/view.php?id=16318)
Reported by: bird_of_Luck
Patches:
      t38-sdp-parsing-fix3.diff uploaded by mnicholson (license 96),
written by vrban and mnicholson
Tested by: vrban, mihaill

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=236261 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-23 09:46 svnbot         Checkin                                      
2009-12-23 09:46 svnbot         Note Added: 0115728                          
======================================================================