[asterisk-bugs] [DAHDI-linux 0013483]: [patch] Add TDMoE Multi-Frame support

Asterisk Bug Tracker noreply at bugs.digium.com
Wed Dec 23 09:29:39 CST 2009


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=13483 
====================================================================== 
Reported By:                JBenden
Assigned To:                kpfleming
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   13483
Category:                   dahdi_dynamic
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
JIRA:                        
Reviewboard Link:            
====================================================================== 
Date Submitted:             2008-09-15 04:17 CDT
Last Modified:              2009-12-23 09:29 CST
====================================================================== 
Summary:                    [patch] Add TDMoE Multi-Frame support
Description: 
A patch against SVN rev 4904, to add TDMoE Multi-Frame support as described
in the article at the following URL:

http://www.thrallingpenguin.com/articles/tdmoe-mf.htm

TDMoE-MF is known to be implemented in hardware solutions from Redfone
Communications.

This patch additionally implements RCU within dahdi_dynamic to decrease
lock contention, latency, and context switching. Because of the use of RCU
locking, all prior known issues with loading and unloading of the modules
are resolved, providing the spans are shutdown with "dahdi_cfg -s".

It also contains an attempt, which works, at fixing a kernel change with
skb_linearize(). The use of kernel version number does not work with SuSE
SLES 10, as it appears they have backported the 2.6.18 change in to their
2.6.16 version.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0012241 [patch] New Ztdynamic driver for Redfon...
====================================================================== 

---------------------------------------------------------------------- 
 (0115726) tomfarnham (reporter) - 2009-12-23 09:29
 https://issues.asterisk.org/view.php?id=13483#c115726 
---------------------------------------------------------------------- 
/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c: In function
‘find_echocan’:
/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c:1125: warning:
format not a string literal and no format arguments
/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c: In function
‘dahdi_ppp_xmit’:
/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c:1755: warning:
comparison of distinct pointer types lacks a cast
/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c:1810: error:
implicit declaration of function ‘print_debug_writebuf’
/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c:1813: warning:
comparison of distinct pointer types lacks a cast
/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c: In function
‘dahdi_chan_ioctl’:
/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c:5020: error:
expected ‘;’ before ‘}’ token


Adding the ';' to the end of line 5020 fixes that.

It then comes up with:

/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c: In function
‘find_echocan’:
/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c:1125: warning:
format not a string literal and no format arguments
/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c: In function
‘dahdi_ppp_xmit’:
/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c:1755: warning:
comparison of distinct pointer types lacks a cast
/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c:1810: error:
implicit declaration of function ‘print_debug_writebuf’
/usr/src/dahdi-linux-redfone-new/drivers/dahdi/dahdi-base.c:1813: warning:
comparison of distinct pointer types lacks a cast


This is based off of revision 5111 and the second patch that was provided. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-23 09:29 tomfarnham     Note Added: 0115726                          
======================================================================




More information about the asterisk-bugs mailing list