[asterisk-bugs] [Asterisk 0016318]: [patch] New SDP handling code totally broke T.38 reinvites

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16318 
====================================================================== 
Reported By:                bird_of_Luck
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   16318
Category:                   Channels/chan_sip/T.38
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.27 
JIRA:                       SWP-594 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-11-24 08:52 CST
Last Modified:              2009-12-22 04:32 CST
====================================================================== 
Summary:                    [patch] New SDP handling code totally broke T.38
reinvites
Description: 
SDP handling code introduced in r227758 effectively sets t38jointcapability
to 0 causing reinvite to fail with reason 'No compatible codecs, not
accepting this offer!'
====================================================================== 

---------------------------------------------------------------------- 
 (0115637) mihaill (reporter) - 2009-12-22 04:32
 https://issues.asterisk.org/view.php?id=16318#c115637 
---------------------------------------------------------------------- 
hello, have a nice day.
Today I try to install Asterisk 1.4.27 on Gentoo
as02# uname -a
Linux as02 2.6.27-gentoo-r8 https://issues.asterisk.org/view.php?id=1 SMP Fri
Mar 27 17:22:51 MSK 2009 i686
Intel(R) Core(TM)2 Quad CPU Q9400 @ 2.66GHz GenuineIntel GNU/Linux
so t38-sdp-parsing-fix1.diff renamed to patch_aster_t38_1.diff and try to
apply, I had a massenge "Failed Patch: patch_aster_t38_1.diff !" when I
lookind log of installation I see 
PATCH COMMAND:   patch -p0 -g0 -E --no-backup-if-mismatch <
/usr/portage/local/layman/voip/net-misc/asterisk/files/1.4/patch_aster_t38_1.diff

==================================
patching file channels/chan_sip.c
Hunk https://issues.asterisk.org/view.php?id=1 FAILED at 5614.
Hunk https://issues.asterisk.org/view.php?id=2 FAILED at 5904.
Hunk https://issues.asterisk.org/view.php?id=3 FAILED at 5918.
Hunk https://issues.asterisk.org/view.php?id=4 FAILED at 5941.
Hunk https://issues.asterisk.org/view.php?id=5 FAILED at 5956.
Hunk https://issues.asterisk.org/view.php?id=6 FAILED at 5968.
Hunk https://issues.asterisk.org/view.php?id=7 FAILED at 5980.
7 out of 7 hunks FAILED -- saving rejects to file channels/chan_sip.c.rej
==================================

PATCH COMMAND:   patch -p1 -g0 -E --no-backup-if-mismatch <
/usr/portage/local/layman/voip/net-misc/asterisk/files/1.4/patch_aster_t38_1.diff

==================================
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- channels/chan_sip.c        (revision 233035)
|+++ channels/chan_sip.c        (working copy)
--------------------------
No file to patch.  Skipping patch.
7 out of 7 hunks ignored
etc... 
so patch don`t apply, I open dirrectory with sourse and look diff manual -
I see that patch already apply, it`s normakky? 
without a patch asterisk build on, so i will test wor t38 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-22 04:32 mihaill        Note Added: 0115637                          
======================================================================