[asterisk-bugs] [Asterisk 0016318]: [patch] New SDP handling code totally broke T.38 reinvites

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16318 
====================================================================== 
Reported By:                bird_of_Luck
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   16318
Category:                   Channels/chan_sip/T.38
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.27 
JIRA:                       SWP-594 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-11-24 08:52 CST
Last Modified:              2009-12-21 19:20 CST
====================================================================== 
Summary:                    [patch] New SDP handling code totally broke T.38
reinvites
Description: 
SDP handling code introduced in r227758 effectively sets t38jointcapability
to 0 causing reinvite to fail with reason 'No compatible codecs, not
accepting this offer!'
====================================================================== 

---------------------------------------------------------------------- 
 (0115622) vrban (reporter) - 2009-12-21 19:20
 https://issues.asterisk.org/view.php?id=16318#c115622 
---------------------------------------------------------------------- 
i could not stand still, there is the fix. The problem was, the Return
after the "Have T.38 but no audio codecs, accepting offer anyway" debug
message, before the t.38 port/ip was set. And since this check is
completely needless (i think), i removed it. now T.38 pass-through is
working for me again. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-21 19:20 vrban          Note Added: 0115622                          
======================================================================