[asterisk-bugs] [Asterisk 0016377]: res_monitor.c chan->monitor->filename_base has duplicated path

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16377 
====================================================================== 
Reported By:                galeras
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16377
Category:                   Resources/res_monitor
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.4.27.1 
JIRA:                       SWP-489 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-12-02 19:16 CST
Last Modified:              2009-12-21 13:43 CST
====================================================================== 
Summary:                    res_monitor.c chan->monitor->filename_base has
duplicated path
Description: 
When res_monitor is mixing the recorded files, calls soxmix with duplicate
paths, for example:

res_monitor.c: monitor executing ( nice -n 19 soxmix
"/var/spool/asterisk/monitor/outbound-20091202-195127-1259801487.116-in.wav"
"/var/spool/asterisk/monitor/outbound-20091202-195127-1259801487.116-out.wav"
"/var/spool/asterisk/monitor/outbound-20091202-195127-1259801487.116.wav" 
&& rm -f
"/var/spool/asterisk/monitor/outbound-20091202-195127-1259801487.116-"* ) &

This happen for inbound calls to a queue. Always reproductible. It seems
the problem is in chan->monitor->filename_base.

We debuged other variables with:

diff res_monitor.c res_monitor.c-20091202
329,333d328
<                       ast_log(LOG_DEBUG,"monitor execute %s\n",execute);
<                       ast_log(LOG_DEBUG,"monitor dir %s\n",dir);
<                       ast_log(LOG_DEBUG,"monitor absolute
%s\n",absolute);
<                       ast_log(LOG_DEBUG,"monitor name %s\n",name);
<                       ast_log(LOG_DEBUG,"monitor format %s\n",format);

With this modified version, full shows:
res_monitor.c: monitor dir
res_monitor.c: monitor absolute
res_monitor.c: monitor name
/var/spool/asterisk/monitor//var/spool/asterisk/monitor/q8007-20091202-195043-1259801443.107
res_monitor.c: monitor format wav


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016376 [patch] Incorrect path passed to MONITO...
====================================================================== 

---------------------------------------------------------------------- 
 (0115584) svnbot (reporter) - 2009-12-21 13:43
 https://issues.asterisk.org/view.php?id=16377#c115584 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 235940

U   branches/1.4/res/res_monitor.c

------------------------------------------------------------------------
r235940 | jpeeler | 2009-12-21 13:43:42 -0600 (Mon, 21 Dec 2009) | 13
lines

Change Monitor to not assume file to write to does not contain pathing.

227944 changed the fname_base argument to always append the configured
monitor
path. This change was necessary to properly compare files for uniqueness. 
If a full path is given though, nothing needs to be appended and that is
handled correctly now.

(closes issue https://issues.asterisk.org/view.php?id=16377)
(closes issue https://issues.asterisk.org/view.php?id=16376)
Reported by: bcnit
Patches:
      res_monitor.c-issue16376-1.patch uploaded by dant (license 670)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=235940 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-21 13:43 svnbot         Checkin                                      
2009-12-21 13:43 svnbot         Note Added: 0115584                          
======================================================================