[asterisk-bugs] [Asterisk 0016318]: [patch] New SDP handling code totally broke T.38 reinvites

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16318 
====================================================================== 
Reported By:                bird_of_Luck
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16318
Category:                   Channels/chan_sip/T.38
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.27 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-11-24 08:52 CST
Last Modified:              2009-12-21 08:11 CST
====================================================================== 
Summary:                    [patch] New SDP handling code totally broke T.38
reinvites
Description: 
SDP handling code introduced in r227758 effectively sets t38jointcapability
to 0 causing reinvite to fail with reason 'No compatible codecs, not
accepting this offer!'
====================================================================== 

---------------------------------------------------------------------- 
 (0115508) vrban (reporter) - 2009-12-21 08:11
 https://issues.asterisk.org/view.php?id=16318#c115508 
---------------------------------------------------------------------- 
yes, it is definite r227758 that broke t.38 passthrough in 1.4 the branch.
What is funny, the comment in the reviewboard*: "Not tested with T.38, but
it should work well." 

Well, t.38 is not working well...

*https://reviewboard.asterisk.org/r/385/ 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-21 08:11 vrban          Note Added: 0115508                          
======================================================================