[asterisk-bugs] [Asterisk 0016384]: [patch] Add support for ring indication when calling member

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16384 
====================================================================== 
Reported By:                haakon
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16384
Category:                   Applications/app_queue
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-479 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 232810 
Request Review:              
====================================================================== 
Date Submitted:             2009-12-03 10:31 CST
Last Modified:              2009-12-18 14:44 CST
====================================================================== 
Summary:                    [patch] Add support for ring indication when calling
member
Description: 
A lot of ACD systems out there play MOH until a member/agent is ready for a
new call, and then plays normal ring indication until you get an answer.

This is a nice thing to have, since the caller might have been in the
queue for quite a while, and put his phone down. As he hears the ring
indication, he have time enough to pick up the phone before the agent
answers.

This introduces a new parameter 'R' to the Queue application.
====================================================================== 

---------------------------------------------------------------------- 
 (0115434) loloski (reporter) - 2009-12-18 14:44
 https://issues.asterisk.org/view.php?id=16384#c115434 
---------------------------------------------------------------------- 
haakon, your patch seems ok for me, though i backport it to SVN 1.4 for my
own needs, will let you know how far it will go. 

this is Asterisk SVN-branch-1.4-r235421M + a few patches. I will try to
test this on trunk tommorow on a test server to confirm this.

a relevant log to confirm this

 -- Executing [s at from-pstn:1] Answer("DAHDI/1-1", "") in new stack
    -- Executing [s at from-pstn:2] Set("DAHDI/1-1", "ID=") in new stack
    -- Executing [s at from-pstn:3] Goto("DAHDI/1-1", "incoming|s|1") in new
stack
    -- Goto (incoming,s,1)
    -- Executing [s at incoming:1] NoOp("DAHDI/1-1", "DEBUG: Incoming
CallerID is : ") in new stack
    -- Executing [s at incoming:2] Set("DAHDI/1-1", "ARRAY(CTYPE|NAME)=") in
new stack
    -- Executing [s at incoming:3] NoOp("DAHDI/1-1", "DEBUG: number of rows
obtained 0| if > 1 it means data redundancy occurs") in new stack
    -- Executing [s at incoming:4] GotoIf("DAHDI/1-1", "1?5:11") in new
stack
    -- Goto (incoming,s,5)
   -- Executing [s at incoming:5] NoOp("DAHDI/1-1", "DEBUG: oops this call
has no callerid is being set") in new stack
    -- Executing [s at incoming:6] Set("DAHDI/1-1", "TID=") in new stack
    -- Executing [s at incoming:7] Set("DAHDI/1-1", "TNAME=") in new stack
    -- Executing [s at incoming:8] Set("DAHDI/1-1", "ID="NO-CALLERID"") in
new stack
    -- Executing [s at incoming:9] Set("DAHDI/1-1", "NAME="NO-NAME"") in new
stack
    -- Executing [s at incoming:10] Set("DAHDI/1-1", "NID=1") in new stack
    -- Executing [s at incoming:11] Set("DAHDI/1-1",
"MONITOR_FILENAME=/var/spool/asterisk/monitor/INBOUND-NO-CALLERID-^{MEMBERNAME}-NO-NAME-12-19-2009-04:54:31")
in new stack
    -- Executing [s at incoming:12] Set("DAHDI/1-1",
"MONITOR_EXEC=/usr/bin/procrecording /var/spool/asterisk/monitor/12-19-2009
/var/spool/asterisk/monitor/INBOUND-NO-CALLERID-^{MEMBERNAME}-NO-NAME-12-19-2009-04:54:31.wav")
in new stack
    -- Executing [s at incoming:13] GotoIf("DAHDI/1-1", "1?14:16") in new
stack
    -- Goto (incoming,s,14)
    -- Executing [s at incoming:14] Set("DAHDI/1-1", "ID=") in new stack
    -- Executing [s at incoming:15] Set("DAHDI/1-1", "NAME=") in new stack
    -- Executing [s at incoming:16] GotoIf("DAHDI/1-1", "1?100") in new
stack
    -- Goto (incoming,s,100)
    -- Executing [s at incoming:100] Goto("DAHDI/1-1", "no_record|s|1") in
new stack
    -- Goto (no_record,s,1)
    -- Executing [s at no_record:1] NoOp("DAHDI/1-1", ""This call has no
record on the database"") in new stack
    -- Executing [s at no_record:2] Set("DAHDI/1-1", "CALLERID(name)=** NO
RECORD **") in new stack
    -- Executing [s at no_record:3] NoOp("DAHDI/1-1", "DEBUG: # of councilors
waiting on queue : 2 out of 2") in new stack
    -- Executing [s at no_record:4] GotoIf("DAHDI/1-1", "1?5:6") in new
stack
    -- Goto (no_record,s,5)
    -- Executing [s at no_record:5] Queue("DAHDI/1-1", "cbn-queue|tR|||180")
in new stack
    -- Started music on hold, class 'default', on DAHDI/1-1
    -- SIP/103-00000002 is ringing
    -- Stopped music on hold on DAHDI/1-1
    -- SIP/103-00000002 answered DAHDI/1-1
  == Begin MixMonitor Recording DAHDI/1-1
  == Parsing '/etc/asterisk/manager.conf': Found 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-18 14:44 loloski        Note Added: 0115434                          
======================================================================