[asterisk-bugs] [Asterisk 0015956]: Transfer to parking lot replies '202 Accepted' rather than '480 Temporarily Unavailable' when lot is full

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15956 
====================================================================== 
Reported By:                Nick_Lewis
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15956
Category:                   Channels/chan_sip/Transfers
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
JIRA:                       SWP-546 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-09-24 12:05 CDT
Last Modified:              2009-12-15 07:57 CST
====================================================================== 
Summary:                    Transfer to parking lot replies '202 Accepted'
rather than '480 Temporarily Unavailable' when lot is full
Description: 
When using sip refer to blind transfer to the parking lot, asterisk always
responds '202 Accepted'. When the parking lot is full it should instead
respond '480 Temporarily Unavailable'.
====================================================================== 

---------------------------------------------------------------------- 
 (0115256) Nick_Lewis (reporter) - 2009-12-15 07:57
 https://issues.asterisk.org/view.php?id=15956#c115256 
---------------------------------------------------------------------- 
Yes I agree that behaviour should be as per other blind transfers to
unavailable destinations. So the failure to park should be reported in the
NOTIFY and not the initial response to the INVITE. 

Irrespectively I think there needs to be a call to ast_park_space_reserve
in order to try to reserve an ast_parkeduser slot before any masquerading
stuff. Otherwise it is difficult to rollback if no slots are found later
on. 

Having looked again I think this reservation probably needs to be right
back at !strcmp(p->refer->refer_to, ast_parking_ext()) rather than in
sip_park or sip_park_thread so these will need to be passed an additional
parameter e.g. struct ast_parkeduser *pu (as of course will ast_park_call) 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-15 07:57 Nick_Lewis     Note Added: 0115256                          
======================================================================