[asterisk-bugs] [Asterisk 0015654]: [patch] Missing new-message notification for urgent messages

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15654 
====================================================================== 
Reported By:                tomo1657
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15654
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.6.1.2 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 210394 
Request Review:              
====================================================================== 
Date Submitted:             2009-08-04 13:23 CDT
Last Modified:              2009-12-07 15:07 CST
====================================================================== 
Summary:                    [patch] Missing new-message notification for urgent
messages
Description: 
notify_new_message() is not called when urgent, new messages are left in a
mailbox using non-IMAP file system storage.

Urgent messages are moved to the "Urgent" folder so the following
condition to check INBOX for the new message (line 5312) is always false,
and notify_new_message() is never called.

  if (ast_fileexists(fn, NULL, NULL)) {

A workaround would be to add an exception for urgent messages:

  if (ast_fileexists(fn, NULL, NULL) && !ast_strlen_zero(flag) &&
!strcmp(flag, "Urgent"))

which I have attacked a patch of.  There are other ways to approach this,
though.  (Run notify_new_message() within the urgent message section or
checking for dfn location instead of fn)
====================================================================== 

---------------------------------------------------------------------- 
 (0114880) tomo1657 (reporter) - 2009-12-07 15:07
 https://issues.asterisk.org/view.php?id=15654#c114880 
---------------------------------------------------------------------- 
The issue continues to exist in the latest svn trunk.  The patch has been
constantly necessary in our deployment; could someone review it?

Urgent messages using file system storage do not trigger
notify_new_messages() with the correct message counts.

I've updated the patch to be compatible with svn revision 233576.  (The
only changes are line numbers, but hoping there will be bigger chance of
being reviewed with the trunk)

To recreate issue:

1) Enable email delivery, set up externnotify path
2) leave an urgent, new message to an empty mailbox using file system
storage
3) The email delivery and extennotify are not triggered since the Urgent
message count is not being counted correctly

Proposed patch:
urgentnotify_v2_233576.patch for "apps/app_voicemail.c"
(Please see previous post for details on what was changed)

URL: http://svn.digium.com/svn/asterisk/trunk
Repository UUID: f38db490-d61c-443f-a65b-d21fe96a405b
Revision: 233576

Thank you! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-07 15:07 tomo1657       Note Added: 0114880                          
======================================================================