[asterisk-bugs] [Asterisk 0016121]: [patch] ExternalIVR TCP client functionality does not work

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16121 
====================================================================== 
Reported By:                thedavidfactor
Assigned To:                thedavidfactor
====================================================================== 
Project:                    Asterisk
Issue ID:                   16121
Category:                   Applications/app_externalivr
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.1.6 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-10-23 13:34 CDT
Last Modified:              2009-12-07 13:48 CST
====================================================================== 
Summary:                    [patch] ExternalIVR TCP client functionality does
not work
Description: 
If you use the ivr:// form of the ExternalIVR argument it fails without
error. I did some investigation discovered that where the
ast_tcptls_session_args gets populated, starting on line 457, the code was
using local_ instead of remote_

Changing this to remote_ causes ExternalIVR to attempt to connect and give
appropriate messages.

I have attached a patch
====================================================================== 

---------------------------------------------------------------------- 
 (0114868) svnbot (reporter) - 2009-12-07 13:48
 https://issues.asterisk.org/view.php?id=16121#c114868 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 233545

U   trunk/apps/app_externalivr.c

------------------------------------------------------------------------
r233545 | diruggles | 2009-12-07 13:48:14 -0600 (Mon, 07 Dec 2009) | 10
lines

Fix TCP Client interface

Fix a couple of very minor bugs that prevent the socket client from
working. The wrong set of properties were used in one place and the size of
the address variable isn't set if the host name is an ip address. Also
includes a fix for a bug that was introduced previously.

(closes issue https://issues.asterisk.org/view.php?id=16121)
Reported by: thedavidfactor
Tested by: thedavidfactor

Review: https://reviewboard.asterisk.org/r/439/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=233545 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-07 13:48 svnbot         Note Added: 0114868                          
======================================================================