[asterisk-bugs] [Asterisk 0016335]: [patch] Asterisk crashes randomly on mISDN RELEASE_COMPLETE

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16335 
====================================================================== 
Reported By:                azielke
Assigned To:                rmudgett
====================================================================== 
Project:                    Asterisk
Issue ID:                   16335
Category:                   Channels/chan_misdn
Reproducibility:            random
Severity:                   crash
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.1.10 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-11-27 07:35 CST
Last Modified:              2009-12-07 05:51 CST
====================================================================== 
Summary:                    [patch] Asterisk crashes randomly on mISDN
RELEASE_COMPLETE
Description: 
I experienced random crashes on an asterisk when an Call over mISDN is hung
up.

The backtrace for the crash always looked similar (see attachment), so i
check the source.
I noticed that there is a check for ch->need_queue_hangup, but it would
just print a message and continue executing the rest of the code.
The fix seems really trivial, but tests show that the asterisk didn't
crash anymore.
====================================================================== 

---------------------------------------------------------------------- 
 (0114831) azielke (reporter) - 2009-12-07 05:51
 https://issues.asterisk.org/view.php?id=16335#c114831 
---------------------------------------------------------------------- 
The Last lines in my log  never where " --> Setting AST State to down" for
me.

Just before the crash, my misdn-log usually showed something very similar
to:
Wed Nov 25 12:10:49 2009: P[ 8]  I IND :RELEASE_COMPLETE oad: dad: pid:538
state:CONNECTED
Wed Nov 25 12:10:49 2009: P[ 8]   --> channel:0 mode:NT cause:16 ocause:16
rad: cad:
Wed Nov 25 12:10:49 2009: P[ 8]   --> info_dad: onumplan:0 dnumplan:0
rnumplan:0 cpnnumplan:0
Wed Nov 25 12:10:49 2009: P[ 8]   --> caps:Speech pi:0 keypad:
sending_complete:0
Wed Nov 25 12:10:49 2009: P[ 8]   --> No need to queue hangup
Wed Nov 25 12:10:49 2009: P[ 8]  * IND : HANGUP pid:538 ctx:hangup
dad:006... oad: State:CONNECTED
Wed Nov 25 12:10:49 2009: P[ 8]   --> l3id:7c0040
Wed Nov 25 12:10:49 2009: P[ 8]   --> cause:16
Wed Nov 25 12:10:49 2009: P[ 8]   --> out_cause:16
Wed Nov 25 12:10:49 2009: P[ 8]   --> Channel: mISDN/15-u744 hungup new
state:CLEANING

And when looking further up in the logs, the interesting lines for this
particular call are:
Wed Nov 25 12:10:49 2009: P[ 8]  I IND :DISCONNECT oad: dad:006... pid:538
state:CONNECTED
Wed Nov 25 12:10:49 2009: P[ 8]   --> channel:1 mode:NT cause:16 ocause:16
rad: cad:006212903929
Wed Nov 25 12:10:49 2009: P[ 8]   --> info_dad:9 onumplan:  dnumplan: 
rnumplan:  cpnnumplan:0
Wed Nov 25 12:10:49 2009: P[ 8]   --> caps:Audio 3.1k pi:0 keypad:
sending_complete:0
Wed Nov 25 12:10:49 2009: P[ 8]   --> org:2 nt:1, inbandavail:0 state:11
Wed Nov 25 12:10:49 2009: P[ 8]   --> queue_hangup

So, it already called ast_queue_hangup_with_cause for this call. The Logs
before the crash even say "No need to queue hangup".


When misdn tries to ast_queue_hangup_with_cause again, it crashed.
When it got called, it tried enable a timer, where the handle was actually
NULL.
So our problems, unfortunately, seem to be different.

Since installing the patch until now, the asterisk didn't crash for me (it
usually crashed at least once per week, tho sometimes even 5 or 6 times per
day). 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-07 05:51 azielke        Note Added: 0114831                          
======================================================================