[asterisk-bugs] [Asterisk 0016279]: [patch] asterisk reload causes mpg123 streams to be recreated

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16279 
====================================================================== 
Reported By:                parisioa
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16279
Category:                   Resources/res_musiconhold
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.6.1.10 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-11-18 18:14 CST
Last Modified:              2009-12-02 18:16 CST
====================================================================== 
Summary:                    [patch] asterisk reload causes mpg123 streams to be
recreated
Description: 
Every time there is an asterisk reload all of the mpg123 streams get
re-started, and the old ones do not get removed.  This causes many many
streams to build up over time, and after enough reloads with enough streams
actually causes asterisk to completely fail.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016207 [patch] asterisk keeps starting new pro...
====================================================================== 

---------------------------------------------------------------------- 
 (0114617) svnbot (reporter) - 2009-12-02 18:16
 https://issues.asterisk.org/view.php?id=16279#c114617 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 232660

U   trunk/include/asterisk/astobj2.h
U   trunk/res/res_musiconhold.c

------------------------------------------------------------------------
r232660 | tilghman | 2009-12-02 18:16:31 -0600 (Wed, 02 Dec 2009) | 19
lines

Fix multiple issues with musiconhold, which led to classes not getting
destroyed properly.
 * Classes are now tracked past removal from the core container, and
module
   removal is actively prevented until all references are freed.
 * A hanging reference stored in the channel has been removed.  This could
have
   caused a mismatch and the music state not properly cleared, if two or
more
   reloads occurred between MOH being stopped and MOH being restarted.
 * In certain circumstances, duplicate classes were possible.
 * A race existed at reload time between a process being killed and the
thread
   responsible for reading from the related pipe respawning that process.
 * Several reference counts have also been corrected.  At least one could
have
   caused deleted classes to stick around forever, consuming resources. 
This
   originally manifested as MOH external processes that were not killed at
   reload time.
(closes issue https://issues.asterisk.org/view.php?id=16279, closes issue
https://issues.asterisk.org/view.php?id=16207)
 Reported by: parisioa, dcabot
 Patches: 
       20091202__issue16279__2.diff.txt uploaded by tilghman (license 14)
 Tested by: parisioa, tilghman

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=232660 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-02 18:16 svnbot         Checkin                                      
2009-12-02 18:16 svnbot         Note Added: 0114617                          
======================================================================