[asterisk-bugs] [Asterisk 0016343]: [patch] New CLI command: manager show settings

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16343 
====================================================================== 
Reported By:                pabelanger
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16343
Category:                   Core/ManagerInterface
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 231401 
Request Review:              
====================================================================== 
Date Submitted:             2009-11-28 17:34 CST
Last Modified:              2009-12-02 12:08 CST
====================================================================== 
Summary:                    [patch] New CLI command: manager show settings
Description: 
Since looking at source is the best way to find default settings for
values, it is not the easy way to find tho.  Following 'sip show settings',
I've added logic to the manager.  

It also helps to see what values are set within Asterisk.
====================================================================== 

---------------------------------------------------------------------- 
 (0114543) tilghman (administrator) - 2009-12-02 12:08
 https://issues.asterisk.org/view.php?id=16343#c114543 
---------------------------------------------------------------------- 
@@ -5627,6 +5678,7 @@
 		} else if (!strcasecmp(var->name, "httptimeout")) {
 			newhttptimeout = atoi(val);
 		} else if (!strcasecmp(var->name, "channelvars")) {
+                	manager_channelvars = ast_strdup(val);
 			struct manager_channel_variable *mcv;
 			char *remaining = ast_strdupa(val), *next;
 			AST_RWLIST_WRLOCK(&channelvars);

Variable declarations must all be at the beginning of a code block.  With
this addition, not only will you leak a string every time channelvars is
encountered in the configuration file, but the following two variable
declarations are now no longer at the beginning of a code block, which is a
violation of the coding guidelines. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-12-02 12:08 tilghman       Note Added: 0114543                          
======================================================================